Conversation
…de/disturbance_calculations.py
…sturbance_test.py
GabrieleMeoni
left a comment
There was a problem hiding this comment.
@GiordanoNesci. The model looks good, but this code shows poor integrability with PASEOS. You also did not create a PR.
Please, make also sure that you merge the last student branch
| """ | ||
|
|
||
| # Set data useful for aerodynamic coefficients calculation | ||
| temperature_spacecraft = 300 # [K] we could connect this with the thermal model |
There was a problem hiding this comment.
There is a thermal model, this is completely disconnected.
There was a problem hiding this comment.
There is the possibility to treat the temperature as an input from the thermal model (when the latter is used). As of now the temperature of the spacecraft is treated as a constant, since the model is not sensitive to the temperatures.
|
|
||
| # Set data useful for aerodynamic coefficients calculation | ||
| temperature_spacecraft = 300 # [K] we could connect this with the thermal model | ||
| temperature_gas = 1000 # [K] valid for upper stratosphere, could be completely wrong higher up |
There was a problem hiding this comment.
This shall be an input or a property of the central body.
| temperature_spacecraft = 300 # [K] we could connect this with the thermal model | ||
| temperature_gas = 1000 # [K] valid for upper stratosphere, could be completely wrong higher up | ||
| altitude = np.linalg.norm(r)-6371 # [km] | ||
| density = 10**(-(altitude+1285)/151) # from data fit from thermospheric mass density |
Reviewed tests and rewritten in pytest
Fixed version of the aero disturbances (there was a j instead of an i in a for loop)
|
The model is almost ready to merge, but there are some minor things to fix:
I do not know if there are any steps missing to make it implementable in the attitude model (e.g. if there is the need to get the mesh from the geometric model, to the attitude model, to the disturbance functions). |
Description
Summary of changes:
Resolved Issues
How Has This Been Tested?
Two types of tests have been created in order to verify and validate the function:
Related Pull Requests
None, attitude model not used in development nor tests.