Skip to content

Visual implementation follow up#39

Merged
gomezzz merged 9 commits intovisual_implementationfrom
visual-implementation-follow-up
Nov 16, 2022
Merged

Visual implementation follow up#39
gomezzz merged 9 commits intovisual_implementationfrom
visual-implementation-follow-up

Conversation

@gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Nov 14, 2022

Description

Summary of changes

  • Changed API to simplify user interaction
  • Fixed problems on win / linux
  • Some minor restyling
  • Refactoring

Resolved Issues

N/A

How Has This Been Tested?

  • example jupyter notebook
  • ran tests

Related Pull Requests

johanos1 and others added 7 commits October 29, 2022 17:00
black and flake8 disagreement on white spaces before colon.
- Fixed plotting on linux
- Added single plot function
- Added logging
- Formatting
- Preparing NB for finalization
@gomezzz gomezzz added visualization Code used to visualize the simulation example An example to showcase something feature implementing a new feature user-facing Anything that users can interact with labels Nov 14, 2022
@gomezzz gomezzz requested a review from johanos1 November 14, 2022 14:37
@gomezzz gomezzz mentioned this pull request Nov 14, 2022
1 task
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gomezzz gomezzz requested a review from johanos1 November 15, 2022 12:26
@gomezzz gomezzz merged commit 538ddc7 into visual_implementation Nov 16, 2022
@gomezzz gomezzz deleted the visual-implementation-follow-up branch November 16, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

example An example to showcase something feature implementing a new feature user-facing Anything that users can interact with visualization Code used to visualize the simulation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants