Warning user if constraint function doesn't return a value

[gomezzz]

Description

Added error in log like this

@GabrieleMeoni I could not find a way to raise an exception inside the async functions. Instead I display an error like above, good enough for now I think?

The original problem of the termination function running twice, I think, was already solved before?

Resolved Issues

• fixes Termination function is executed twice if the constraint function has no return value #44

How Has This Been Tested?

Specific test

Related Pull Requests

N/A

[GabrieleMeoni]

I don't get any warning. I used the notebook attached to test it. What am I doing wrong?
notebook.zip

[gomezzz]

I don't get any warning. I used the notebook attached to test it. What am I doing wrong? notebook.zip

You activity is too short. The constraint is never checked because it runs less than a second. If I increase the sleep in the activity to two seconds, it works for me. Can you check?

[GabrieleMeoni]

Yes, tested and works as expected for an activity lasting 2 seconds. Should we add an issue to notify the user about this problem? (You set a constraint function but the activity is too short and will never get tested.)? @gomezzz

[gomezzz]

Yes, tested and works as expected for an activity lasting 2 seconds. Should we add an issue to notify the user about this problem? (You set a constraint function but the activity is too short and will never get tested.)? @gomezzz

@GabrieleMeoni Hm, depends, maybe we should be checking the constraint once before we start the activity? If so, then yes