Merged
Conversation
GabrieleMeoni
added
documentation
added 2 commits
December 12, 2022 19:46
gomezzz
requested changes
Dec 12, 2022
Collaborator
gomezzz
left a comment
gomezzz
left a comment
There was a problem hiding this comment.
I like where it's going! I have to do something else now, will give more comments in the next iteration of review
README.md
Outdated
| ``` | ||
|
|
||
| ### How to add a power device | ||
| The following code snippet shows how to add a power device to `SatA`. |
Collaborator
There was a problem hiding this comment.
Explain briefly that we support solar power only atm and that it will charge when not in eclipse. Also, we should only support one power device right now, I think? 🤔 probably everything breaks if you try to add a second? 🤔
Collaborator
Author
There was a problem hiding this comment.
I never tried...
gomezzz
reviewed
Dec 12, 2022
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
This was referenced Dec 19, 2022
Merged
gomezzz
requested changes
Dec 19, 2022
Collaborator
gomezzz
left a comment
gomezzz
left a comment
There was a problem hiding this comment.
see suggestions 🙏
love the linking to glossary btw 💪
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Fixing grammar.
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added README
Summary of changes
Improving README by adding:
Missing