Add fixes from sun_alf:core, sync-up with 1.13 rev. 8872 / GameDir 2558#17
Open
sun-alf wants to merge 18 commits into
Open
Add fixes from sun_alf:core, sync-up with 1.13 rev. 8872 / GameDir 2558#17sun-alf wants to merge 18 commits into
sun-alf wants to merge 18 commits into
Conversation
AIMNAS files were updated to 8790 / GameDir 2529
* Reset throwing knives modifier * Correct typo of a shotgun modifier * Remove garbage/redundant/obsolete files
No need to copy original (english) *.EDT files to /NPCDATA directory. Everything is proven to work without this stuff -- the game loads original files from original SLF pa ckages automatically.
* EDT files were removed. * Added missed cound file "Ceramic Armour Insert.wav". * Skyrider escorting quest: fix of Heli position. * APBP, CTH tune-ups. * COVER_SYSTEM tune-ups and other minor changes (balancing).
Update to JA2 1.13 rev 8806 / GameDir 2534
* New feature: the refilling of the queen's army resevere now requires her to train recruits, which the player can disrupt to some degree (by sun_alf). * There can now be effectively unlimited battle sounds for NPCs. Activated some NPC voices that never played. * New disease options: fire damage, legs/arms injures. * Merc disabilities: multiple disabilities are allowed.
NPC list: Betty, Lee Johnston, Harvey Johnston, Jorge See History: Massive AIMNAS update to JA2 1.13 rev 8790 / GameDir 2529 (May 20, 2020)
Numbers in CoolnessBySector.xml affect spying, turncoats, coolness of newly created soldiers, intelligence and other stuff. So it should be filled properly for balanced gameplay. Also, fixed typo in FacilityTypes.xml.
|
Oh awesome, thanks for your work! |
Contributor
Author
|
Welcome! |
Franbo
reviewed
Aug 22, 2020
| <InfectionChance_WOUND_OPEN>0</InfectionChance_WOUND_OPEN> | ||
| <InfectionChance_WOUND_GUNSHOT>0</InfectionChance_WOUND_GUNSHOT> | ||
| <InfectionChance_WOUND_FIRE>0</InfectionChance_WOUND_FIRE> | ||
| <InfectionChance_WOUND_GAS>100</InfectionChance_WOUND_GAS> |
Contributor
There was a problem hiding this comment.
Does this trigger on any gas like tear gas, or only mustard gas?
Franbo
reviewed
Aug 22, 2020
| <fSpecialFlagLimitedUseArms>0</fSpecialFlagLimitedUseArms> | ||
| <fSpecialFlagLimitedUseLegs>0</fSpecialFlagLimitedUseLegs> | ||
| <sEffStatAGI>0</sEffStatAGI> | ||
| <sEffStatDEX>-40</sEffStatDEX> |
Contributor
There was a problem hiding this comment.
This is really extreme for unspecified burn locations. Burns after initial treatment shouldn't have a big impact unless they're somewhere like hands or feet.
Franbo
reviewed
Aug 22, 2020
| <usMaxBreath>60</usMaxBreath> | ||
| <sEffCarryStrength>0</sEffCarryStrength> | ||
| <sLifeRegenHundreds>-200</sLifeRegenHundreds> | ||
| <sNeedToSleep>0</sNeedToSleep> |
Contributor
There was a problem hiding this comment.
With difficulty breathing, merc might need to sleep more?
Franbo
reviewed
Aug 22, 2020
| ; around the target tile. The better a merc is with grenades or mortar (check the traits) the higher will be his Chance to Hit | ||
| ; and the smaller will be the final radius. | ||
| ; Valid values are from 0 to 30. | ||
| MISS_MAX_RADIUS_GRENADE = 5; |
Contributor
There was a problem hiding this comment.
Did this get moved to another file?
Contributor
Author
There was a problem hiding this comment.
it is an accident copy of these 2 params. Original params are at lines 355-356
Franbo
approved these changes
Aug 22, 2020
Contributor
Franbo
left a comment
Franbo
left a comment
There was a problem hiding this comment.
Overall looks good to me!
…/roof collapsing The bug appears independing on ADD_SMOKE_AFTER_EXPLOSION option -- because of lacking two items of explosives type in AIMNAS: * Roof collapse smoke * Smoke Grenade ID 151 (Rack of RFM-1 is here instead) Shortly, once an explosion happened, the game adds explosions effects of item ID 151 to the exploded tile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.