Fix memory leak and improve performance (closes #8) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a memory leak due to calling ctx.save() without a corresponding restore. Improve performance by allowing Throbber.loop() to unschedule when throbber stops, rescheduling when throbber is started. Similarly, allow tick() to stop when no active throbbers, restarting when a throbber is started.
Author
|
bump |
|
I ran into that problem. Thanks for providing a fix @lordmauve 👍 |
|
Thanks for fixing this problem. This PR should really be merged into master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak due to calling ctx.save() without a corresponding
restore.
Improve performance by allowing Throbber.loop() to unschedule when
throbber stops, rescheduling when throbber is started.
Similarly, allow tick() to stop when no active throbbers, restarting
when a throbber is started.