Skip to content

Conversation

@samuelcolvin
Copy link
Member

Fix #237.

Problem was with any alternative loop.

@NewUserHa please check this and confirm it works for you.

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #238 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          13       13           
  Lines         754      754           
  Branches       88       88           
=======================================
  Hits          718      718           
  Misses         23       23           
  Partials       13       13
Impacted Files Coverage Δ
aiohttp_devtools/runserver/config.py 84.95% <100%> (-0.14%) ⬇️
aiohttp_devtools/runserver/serve.py 95.85% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 689f35f...b3ad2cf. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #238 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          13       13           
  Lines         754      754           
  Branches       88       88           
=======================================
  Hits          718      718           
  Misses         23       23           
  Partials       13       13
Impacted Files Coverage Δ
aiohttp_devtools/runserver/config.py 84.95% <100%> (-0.14%) ⬇️
aiohttp_devtools/runserver/serve.py 95.85% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 689f35f...b3ad2cf. Read the comment docs.

@samuelcolvin samuelcolvin merged commit cc90664 into master Jun 19, 2019
@samuelcolvin samuelcolvin deleted the fix-alt-loop branch June 19, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dont work with ProactorEventLoop?

2 participants