Skip to content

try hack to fix grablib logging#335

Merged
samuelcolvin merged 1 commit intoDreamsorcerer-patch-5from
fix-grablib-logging
Sep 12, 2021
Merged

try hack to fix grablib logging#335
samuelcolvin merged 1 commit intoDreamsorcerer-patch-5from
fix-grablib-logging

Conversation

@samuelcolvin
Copy link
Copy Markdown
Member

try to fix error from grablib on windows.

@samuelcolvin
Copy link
Copy Markdown
Member Author

tests aren't running this PR isn't against master, I'll merge it into your branch @Dreamsorcerer to test it

@samuelcolvin samuelcolvin merged commit b6a2cad into Dreamsorcerer-patch-5 Sep 12, 2021
@samuelcolvin samuelcolvin deleted the fix-grablib-logging branch September 12, 2021 13:25
Dreamsorcerer added a commit that referenced this pull request Sep 12, 2021
* Reenable Windows tests

* try hack to fix grablib logging (#335)

* windows tests passing incorrectly

* Use async with

* Ignore python internal warnings

Co-authored-by: Samuel Colvin <s@muelcolvin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant