Allow manually recovering from OOB row when off by one#9
Open
airblast-dev wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Adrien Clauzel clauzeladrien@gmail.com
|
Thanks a lot ! This is much cleaner than my last commit 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current design is intended to be tolerant to errors from a client or server.
However in some cases we strictly want to control the recovery to be performed. This makes it so an error is returned even when the row index is off by one.
@adclz in case you wanna check it out before its merged or think something should be added.