changes to how strings are concatenated#130
Closed
maciej-gurban wants to merge 1 commit intoairbnb:masterfrom
maciej-gurban:master
Closed
changes to how strings are concatenated#130maciej-gurban wants to merge 1 commit intoairbnb:masterfrom maciej-gurban:master
maciej-gurban wants to merge 1 commit intoairbnb:masterfrom
maciej-gurban:master
Conversation
|
👎 this is like the comma-first practice. It may have purpose, but too many people do and will take the previous as the standard. |
Contributor
|
This kind of goes against the leading commas section, in my opinion. It makes the text harder to read. |
Contributor
|
@drkibitz five hour old pull request, 10 second appart answers. |
|
@nmussy Just having my morning ☕ and reading Github notifications 😎 |
Contributor
|
@drkibitz Catching up on the day's notification here, being GMT + 1 and all. That probably makes it funnier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the way strings are concatenated, by making the concatenation at the beginning of a line, which seems like a bit cleaner solution.