Big update with better conventions#138
Closed
jeroenransijn wants to merge 2 commits intoairbnb:masterfrom
Closed
Conversation
Changed some stuff related to Aan Zee
Reordered blog links
Author
|
Didn't want to do this instead wanted to merge my master branch with the Aan Zee master branch. |
|
Then close this PR, and open one there? |
Member
|
Thanks for checking out the guide! I'm going to close this so there's no confusion. 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better conventions for boolean var names, function/method definitions with a space between the name opposed to invoking a function/method to distinguish the two. Use multiline var expressions instead of comma separated for vars with values. Included a section about a solid toType function.