[DO NOT MERGE!] Different way of declaring variables.#147
Closed
jakubpawlowicz wants to merge 1 commit intoairbnb:masterfrom
moneyadviceservice:proposals/variables
Closed
[DO NOT MERGE!] Different way of declaring variables.#147jakubpawlowicz wants to merge 1 commit intoairbnb:masterfrom moneyadviceservice:proposals/variables
jakubpawlowicz wants to merge 1 commit intoairbnb:masterfrom
moneyadviceservice:proposals/variables
Conversation
Contributor
|
This was already discussed recently, in this issue here: #143 The debate was closed off early, but it'd be nice to continue the discussion as there are indeed valid points for both methods. |
Author
|
Sorry, GitHub by mistake pointed this PR to your repository not our fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What if we move away from declaring all variables with one
varto using onevarper variable?It reads better (no need to argue on how to indent 2nd and further lines) and it's not our job to optimise code manually.
Any thoughts?