Ambiguous 'good' example#1637
Closed
vorpus wants to merge 2 commits intoairbnb:masterfrom
vorpus:patch-1
Closed
Conversation
7.11 uses the 'bad' example from 7.1. Changed to arrow function to prevent ambiguity.
ljharb
requested changes
Nov 8, 2017
|
|
||
| // good | ||
| const x = function () {}; | ||
| const x = () => {}; |
Collaborator
There was a problem hiding this comment.
an arrow function doesn't have the spacing issue this section is concerned with; the fact that function () {} is bad doesn't mean it's not useful in this example.
I'm fine adding the arrow, but we need to keep the function () {}.
Author
There was a problem hiding this comment.
@ljharb Yea I was thinking about that after I made the PR - added line 811 with a function that has a longer lexical name
Author
There was a problem hiding this comment.
@ljharb You're probably right, it's too trivial of an inconsistency to not keep what is currently in the doc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7.11 uses the 'bad' example from 7.1. Changed to arrow function to prevent ambiguity.