Clarify single newlines at the end of files.#170
Merged
hshoff merged 1 commit intoairbnb:masterfrom May 14, 2014
Merged
Conversation
Contributor
|
Might it be worth mentioning https://help.github.com/articles/dealing-with-line-endings ? |
Member
|
🍻 |
hshoff
added a commit
that referenced
this pull request
May 14, 2014
Clarify single newlines at the end of files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process of adopting a variant of this guide at reddit, we encountered some ambiguity in the wording / examples of EOF style. It is possible to interpret the current wording as "add an extra blank newline at the end of each file", leading to double newlines. Unicode to the rescue!
cc @ajacksified