Merged
Conversation
Collaborator
|
LGTM, but this may be controversial with the original guide authors? Some people complained about having exports other than at the very bottom of the file. |
Collaborator
|
In this specific case, I like this change, because 100% of the code below the default export is something that will be moved into inline |
Contributor
Author
|
If the goal is to place all exports at the bottom, then at least one code example needs to be updated. |
Collaborator
|
yeah sure |
Collaborator
|
(I opened #492 to fix that code example) |
Collaborator
|
I'm merging this because I agree and discussion stopped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b more 1337