[eslint config] [breaking] enable quote-props rule.#632
Merged
Conversation
ljharb
force-pushed
the
ljharb/quote_props
branch
from
b559d45 to
ce48093
Compare
ljharb
force-pushed
the
ljharb/quote_props
branch
5 times, most recently
from
6d479cb to
1ab2f02
Compare
ljharb
force-pushed
the
ljharb/quote_props
branch
7 times, most recently
from
960506e to
4cdc3fe
Compare
ljharb
added a commit
that referenced
this pull request
Jan 4, 2016
[eslint config] [breaking] enable `quote-props` rule.
| // require quotes around object literal property names | ||
| 'quote-props': 0, | ||
| // http://eslint.org/docs/rules/quote-props.html | ||
| 'quote-props': [2, 'as-needed', { 'keywords': true, 'unnecessary': true, 'numbers': false }], |
Collaborator
Author
There was a problem hiding this comment.
Since we recommend using babel, which takes care of quoting reserved property names in legacy engines, this is not a concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the rule we follow at Airbnb, but the styleguide and linter plugin haven't been enforcing it.