Remove whitespace before function call parens#668
Closed
sahat wants to merge 1 commit intoairbnb:masterfrom
Closed
Remove whitespace before function call parens#668sahat wants to merge 1 commit intoairbnb:masterfrom
sahat wants to merge 1 commit intoairbnb:masterfrom
Conversation
Having a space here is a bit distracting for 2 reasons: 1) This rule is about using soft tabs over tabs 2) "// good" goes against violation of [18.3](https://github.com/airbnb/javascript#18.3) that says "*Place no space before the argument list in function calls and declarations.*"
Collaborator
|
There must always be a space after the I've tweaked 18.3 to make this clear. |
ljharb
added a commit
that referenced
this pull request
Jan 8, 2016
gilbox
pushed a commit
to gilbox/javascript
that referenced
this pull request
Mar 21, 2016
jaylaw81
pushed a commit
to appirio-digital/ads-best-practices
that referenced
this pull request
Sep 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a space here is a bit distracting for 2 reasons:
// goodgoes against violation of 18.3 that says "Place no space before the argument list in function calls and declarations."