Chore: vite.config.jsのtargetをtsconfig.jsonに合わせる
#496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that it matches the `tsconfig.json`
FineArchs
approved these changes
Dec 3, 2023
MineCake147E
changed the title
vite.config.jsのtargetをtsconfig.jsonに合わせるvite.config.jsのtargetをtsconfig.jsonに合わせる
Member
|
https://github.com/aiscript-dev/aiscript/blob/master/docs/contribution/index.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
aiscript/tsconfig.json
Line 11 in 23764a6
こう指定されているにも拘わらず、
playgroundのViteではes2022ではなくes2019が指定されていることが判明しました。これにより、
tsconfig.jsonとの矛盾が生じていたので、vite.config.jsからtsconfig.jsonのcompilerOptions.targetを読み込むことにより解消します。Why
#489 の解決で使用する予定の
BigIntのリテラルがplaygroundのビルドエラーの原因になっていました。aiscriptのビルドは動作していたのでviteを疑いました。Additional info (optional)
Node.jsやViteは素人なので、この方法が適切かどうかはわかりません。
御指南頂けますと幸いです。