Skip to content

Conversation

@uzmoi
Copy link
Member

@uzmoi uzmoi commented Aug 31, 2024

What

validateKeywordでnull, true, falseがエラーになるように修正

Why

Fix #773

Additional info (optional)

キーワードのテストは #678 (comment) とのことで変えていません。

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/parser/plugins/validate-keyword.ts 63.63% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/interpreter/index.ts 94.07% <100.00%> (+8.27%) ⬆️
src/parser/syntaxes/statements.ts 97.42% <ø> (+4.17%) ⬆️
src/parser/plugins/validate-keyword.ts 85.60% <63.63%> (-3.02%) ⬇️

... and 27 files with indirect coverage changes

@uzmoi uzmoi changed the title fix: destr define fix: 宣言での分割代入の修正 Aug 31, 2024
@uzmoi
Copy link
Member Author

uzmoi commented Aug 31, 2024

each文とfor文にもletありますけど、forはnum型しか入ってこないからいいとして、eachでも分割代入対応したほうがいいですかね

@salano-ym
Copy link
Member

assignと挙動に合わせてawait Promise.allはそのままでいいと思います。

@salano-ym
Copy link
Member

eachでも分割代入対応したほうがいいですかね

別PRで追加しても良いと思います。jsみたいに仮引数も分割できると便利?

@uzmoi
Copy link
Member Author

uzmoi commented Aug 31, 2024

バグ修正は即マージできることに気づいたのでマージします。

@uzmoi uzmoi merged commit 79db81e into aiscript-dev:master Aug 31, 2024
@uzmoi uzmoi deleted the fix-destr-define branch August 31, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

let false = 'hoge'がエラーにならない

3 participants