Conversation
WalkthroughTwo new environment variables, Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/deploy-web/env/.env (1)
16-17: Confirm infra & docs are updated for the new/console-provider-proxyroute (HTTP + WS)
Changing both HTTP and WebSocket proxy prefixes means every place that terminates or rewrites these paths (k8s Ingress, CloudFront, Nginx, localnext.config.js, etc.) must now be aware of/console-provider-proxy. Make sure:
• All environments (dev, staging, prod) expose the new path and still forwardUpgrade: websocketheaders correctly.
• Any hard-coded URLs in scripts, CI/CD, or docs are updated or will fall back via redirect.
• Old/provider-proxyendpoints are either removed or 301-redirected to avoid breaking old links.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/deploy-web/env/.env(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ygrishajev
PR: akash-network/console#1461
File: apps/notifications/src/modules/alert/services/deployment-alert/deployment-alert.service.ts:194-197
Timestamp: 2025-06-10T14:19:14.122Z
Learning: The alert.CONSOLE_WEB_URL environment variable in the notifications app is controlled and configured by the Akash team, reducing XSS concerns for HTML link generation in alert messages.
apps/deploy-web/env/.env (2)
Learnt from: ygrishajev
PR: akash-network/console#1461
File: apps/notifications/src/modules/alert/services/deployment-alert/deployment-alert.service.ts:194-197
Timestamp: 2025-06-10T14:19:14.122Z
Learning: The alert.CONSOLE_WEB_URL environment variable in the notifications app is controlled and configured by the Akash team, reducing XSS concerns for HTML link generation in alert messages.
Learnt from: stalniy
PR: akash-network/console#1353
File: apps/deploy-web/src/config/browser-env.config.ts:0-0
Timestamp: 2025-05-22T14:25:01.336Z
Learning: For the `__AK_INJECTED_CONFIG__` global window property in the Akash Network Console, security is handled through cryptographic signature verification using a public key rather than property protection mechanisms like Object.defineProperty.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: validate / validate-app
- GitHub Check: test-build
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
=======================================
Coverage 41.96% 41.96%
=======================================
Files 876 876
Lines 21339 21339
Branches 3874 3874
=======================================
Hits 8954 8954
Misses 12202 12202
Partials 183 183
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/deploy-web/env/.env.production(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ygrishajev
PR: akash-network/console#1461
File: apps/notifications/src/modules/alert/services/deployment-alert/deployment-alert.service.ts:194-197
Timestamp: 2025-06-10T14:19:14.122Z
Learning: The alert.CONSOLE_WEB_URL environment variable in the notifications app is controlled and configured by the Akash team, reducing XSS concerns for HTML link generation in alert messages.
Learnt from: stalniy
PR: akash-network/console#1353
File: apps/deploy-web/src/config/browser-env.config.ts:0-0
Timestamp: 2025-05-22T14:25:01.336Z
Learning: For the `__AK_INJECTED_CONFIG__` global window property in the Akash Network Console, security is handled through cryptographic signature verification using a public key rather than property protection mechanisms like Object.defineProperty.
apps/deploy-web/env/.env.production (1)
Learnt from: ygrishajev
PR: akash-network/console#1461
File: apps/notifications/src/modules/alert/services/deployment-alert/deployment-alert.service.ts:194-197
Timestamp: 2025-06-10T14:19:14.122Z
Learning: The alert.CONSOLE_WEB_URL environment variable in the notifications app is controlled and configured by the Akash team, reducing XSS concerns for HTML link generation in alert messages.
🪛 Gitleaks (8.26.0)
apps/deploy-web/env/.env.production
50-50: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: validate / validate-app
- GitHub Check: test-build
- GitHub Check: validate (apps/deploy-web) / validate-unsafe
🔇 Additional comments (1)
apps/deploy-web/env/.env.production (1)
50-50: Gitleaks flagged the Stripe publishable key—verify but likely safe.Line 50 was reported as a “Generic API Key”. Stripe publishable keys are intentionally public and safe to embed in client bundles, so this is usually a false positive. Still, ensure it is the publishable (pk_live/ pk_test) key and not a secret key (sk_live/ sk_test) before dismissing the warning.
* fix(config): replace proxy url * fix(auth): provider proxy url * fix(auth): staging provider proxy urls * fix(auth): remove values from the .env file
2 participants
Summary by CodeRabbit