Skip to content

feat(billing): update tos#1671

Merged
baktun14 merged 3 commits intomainfrom
features/update-tos
Jul 15, 2025
Merged

feat(billing): update tos#1671
baktun14 merged 3 commits intomainfrom
features/update-tos

Conversation

@baktun14
Copy link
Contributor

@baktun14 baktun14 commented Jul 12, 2025

Summary by CodeRabbit

  • Style

    • Improved the layout and readability of the privacy policy page for a better user experience.
  • Refactor

    • Updated internal wallet management logic and structure to enhance maintainability. No changes to user-facing functionality.

@baktun14 baktun14 requested a review from a team as a code owner July 12, 2025 11:04
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 12, 2025

Walkthrough

The updates include relocating a useEffect hook within a wallet management hook, restructuring the privacy policy page for improved layout without changing its content, and refactoring the wallet store export from an anonymous object to a named constant. No public APIs or logic were altered beyond these structural adjustments.

Changes

File(s) Change Summary
apps/deploy-web/src/hooks/useManagedWallet.ts Moved a useEffect hook to a later position within the custom hook; logic and dependencies unchanged.
apps/deploy-web/src/pages/privacy-policy/index.tsx Wrapped privacy policy content in a styled container for better layout; no text or logic changes.
apps/deploy-web/src/store/walletStore.ts Changed default export from anonymous object to named constant walletStore with same properties.

Poem

In the warren, code hops anew,
Hooks shift their burrows, as rabbits do.
The privacy page now sits with grace,
While wallet stores find a named place.
With every change, we leap ahead—
Lettuce and logic, well-fed! 🥕

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-12T11_06_04_529Z-debug-0.log

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Jul 12, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.10%. Comparing base (df003dd) to head (4b56248).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
apps/deploy-web/src/hooks/useManagedWallet.ts 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (40.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1671   +/-   ##
=======================================
  Coverage   72.09%   72.10%           
=======================================
  Files         590      590           
  Lines       13670    13671    +1     
  Branches     2299     2298    -1     
=======================================
+ Hits         9856     9857    +1     
- Misses       3498     3593   +95     
+ Partials      316      221   -95     
Flag Coverage Δ *Carryforward flag
api 79.97% <ø> (ø) Carriedforward from df003dd
deploy-web 56.19% <40.00%> (+<0.01%) ⬆️
notifications 87.90% <ø> (ø) Carriedforward from df003dd
provider-proxy 84.23% <ø> (ø) Carriedforward from df003dd

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
apps/deploy-web/src/store/walletStore.ts 100.00% <100.00%> (ø)
apps/deploy-web/src/hooks/useManagedWallet.ts 23.07% <0.00%> (ø)

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
apps/deploy-web/src/store/walletStore.ts (1)

8-14: Consider typing / freezing walletStore for stronger safety
Annotating the object either with an explicit interface or as const will preserve atom value types when the store is imported elsewhere and prevent accidental mutation.

-const walletStore = {
+export const walletStore = {
   isSignedInWithTrial,
   selectedWalletType,
   isWalletModalOpen
-};
-
-export default walletStore;
+} as const;

If you don’t need the default export anymore, switching to a named export improves tree-shaking and avoids mixed import styles.

apps/deploy-web/src/pages/privacy-policy/index.tsx (1)

18-180: Great readability upgrade – consider extracting to MD for maintainability
Wrapping the policy in a centred container markedly improves UX. As the document grows, you might push the raw HTML into a Markdown file and render it with next-mdx-remote/similar to keep the page component slim.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df003dd and 4b56248.

📒 Files selected for processing (3)
  • apps/deploy-web/src/hooks/useManagedWallet.ts (1 hunks)
  • apps/deploy-web/src/pages/privacy-policy/index.tsx (1 hunks)
  • apps/deploy-web/src/store/walletStore.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: validate / validate-app
  • GitHub Check: test-build
🔇 Additional comments (1)
apps/deploy-web/src/hooks/useManagedWallet.ts (1)

27-31: Effect relocation looks correct
Moving this useEffect after atom initialisation removes the risk of using an un-initialized setter; dependency list is still stable and no new render loop is introduced.

@baktun14 baktun14 merged commit 80d4048 into main Jul 15, 2025
56 of 57 checks passed
@baktun14 baktun14 deleted the features/update-tos branch July 15, 2025 11:14
stalniy pushed a commit that referenced this pull request Nov 20, 2025
* feat(billing): update terms of service

* fix: update tos email to

* fix: update consistent privacy policy styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments