fix(log-collector): properly extracts image version for ci build#1717
Merged
ygrishajev merged 1 commit intomainfrom Jul 22, 2025
Merged
fix(log-collector): properly extracts image version for ci build#1717ygrishajev merged 1 commit intomainfrom
ygrishajev merged 1 commit intomainfrom
Conversation
Contributor
WalkthroughThe GitHub Actions workflow for releasing the log-collector Docker image was updated to refine the image tagging process. Instead of using the full git tag as the Docker image tag, the workflow now extracts a simplified version string to use as the tag, removing any prefix and leading 'v' character. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Git
participant Docker
GitHub Actions->>Git: Get git tag
Git->>GitHub Actions: Return full git tag
GitHub Actions->>GitHub Actions: Extract version (remove prefix and 'v')
GitHub Actions->>Docker: Build image with sanitized version tag
GitHub Actions->>Docker: Push image with sanitized version tag
Estimated code review effort1 (~2 minutes) Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ygrishajev
force-pushed
the
feature/log-collector
branch
from
f8d9e4c to
faaac09
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/log-collector-release.yml (1)
42-43: Considerdocker buildx build --pushfor multi-arch images and fewer steps.Using Buildx with
--pushpushes the manifest and layers atomically and enables--platformfor multi-architecture support, which is increasingly expected for GitHub-hosted images.-docker build -f apps/log-collector/Dockerfile -t "$image" . -docker push "$image" +docker buildx build \ + --file apps/log-collector/Dockerfile \ + --tag "$image" \ + --push \ + --platform linux/amd64,linux/arm64 .This is optional but future-proofs the release pipeline.
baktun14
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit