refactor: migrate provider-proxy to next chain sdk

[stalniy]

Why

closes #1920

Summary by CodeRabbit

• Bug Fixes
  • Updated certificate lookup to the latest API endpoint, ensuring reliable certificate retrieval with providers using v1 endpoints and preventing failures when legacy paths are unavailable.
• Chores
  • Updated TypeScript build settings for modern Node module resolution and import handling, improving build stability and compatibility.
• Tests
  • Aligned test server routing with the new certificate endpoint to maintain accurate test coverage.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updates the certificate list API path from v1beta3 to v1 in ProviderService and its test server. Adjusts TypeScript build configuration to NodeNext module resolution with TS extension handling enabled. No public APIs or exported declarations changed.

Changes

Cohort / File(s)	Summary
Certificates API version bump apps/provider-proxy/src/services/ProviderService/ProviderService.ts, apps/provider-proxy/test/setup/chainApiServer.ts	Replace certificate list endpoint path from /akash/cert/v1beta3/certificates/list to /akash/cert/v1/certificates/list; preserve existing retry logic, error handling, and test server behavior.
Build configuration apps/provider-proxy/tsconfig.build.json	Add module: "NodeNext", allowImportingTsExtensions: true, and rewriteRelativeImportExtensions: true; minor lib array formatting update.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Client
  participant ProviderService
  participant ChainAPI as Chain API

  Client->>ProviderService: getCertificate(serial, providerCN)
  rect rgb(237, 245, 255)
    note right of ProviderService: HTTP fetch with retry on 5xx
    ProviderService->>ChainAPI: GET /akash/cert/v1/certificates/list
    alt 2xx response
      ChainAPI-->>ProviderService: certificates[]
      ProviderService-->>Client: matching certificate or not found
    else 5xx error
      ChainAPI--x ProviderService: error
      ProviderService->>ChainAPI: retry (per policy)
      note over ProviderService,ChainAPI: Retries until success or limit reached
    else other error
      ChainAPI--x ProviderService: 4xx/Network error
      ProviderService-->>Client: error propagated
    end
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• ygrishajev
• baktun14

Poem

I hop between versions, swift as the breeze,
From beta to v1 with elegant ease.
My whiskers twitch—TypeScript’s set just right,
NodeNext moon guiding imports by night.
Carrots cached, retries tight—
Certificates found, all clear in sight. 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Linked Issues Check	⚠️ Warning	While the pull request correctly replaces all hardcoded "v1beta3" API paths with "v1", it does not demonstrate actual integration of the ChainSDK package itself or removal of manual HTTP calls in favor of SDK methods, leaving the objective of migrating to the new SDK unfulfilled.	Please integrate ChainSDK calls in place of manual fetch logic and add the necessary imports and usage examples to satisfy the objective of migrating to the new SDK.
Out of Scope Changes Check	⚠️ Warning	The modifications to tsconfig.build.json introducing NodeNext module resolution and import extension settings are not mentioned in the linked issue’s objectives and do not directly relate to updating API version strings or integrating ChainSDK, indicating configuration changes outside the specified scope.	Remove or justify the tsconfig.build.json modifications or explicitly tie them to ChainSDK integration requirements to ensure all changes align with the linked issue scope.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "refactor: migrate provider-proxy to next chain sdk" clearly and concisely summarizes the primary change of the pull request, which is updating the provider-proxy to align with the next version of the Chain SDK by bumping the API endpoint version and adjusting configurations.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 83.91960% with 32 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main-sdk-next@62b1901). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../PaymentPollingProvider/PaymentPollingProvider.tsx	84.61%	14 Missing and 2 partials ⚠️
apps/deploy-web/src/pages/payment.tsx	0.00%	5 Missing and 1 partial ⚠️
...t/repositories/deployment/deployment.repository.ts	80.00%	4 Missing ⚠️
.../deployment-reader/db-deployment-reader.service.ts	95.55%	2 Missing ⚠️
apps/deploy-web/src/hooks/useManagedWallet.ts	0.00%	2 Missing ⚠️
...oy-web/src/context/PaymentPollingProvider/index.ts	0.00%	1 Missing ⚠️
apps/deploy-web/src/pages/_app.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##             main-sdk-next    #1980   +/-   ##
================================================
  Coverage                 ?   45.06%           
================================================
  Files                    ?      993           
  Lines                    ?    28097           
  Branches                 ?     7416           
================================================
  Hits                     ?    12662           
  Misses                   ?    14314           
  Partials                 ?     1121           

Flag	Coverage Δ		*Carryforward flag
api	81.57% <92.50%> (?)
deploy-web	23.71% <77.77%> (?)
notifications	87.94% <ø> (?)		Carriedforward from 384080c
provider-console	81.48% <ø> (?)		Carriedforward from 384080c
provider-proxy	84.98% <100.00%> (?)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...c/deployment/http-schemas/deployment-rpc.schema.ts	100.00% <100.00%> (ø)
...eployment/routes/deployments/deployments.router.ts	97.10% <100.00%> (ø)
apps/deploy-web/src/queries/queryKeys.ts	100.00% <100.00%> (ø)
...ps/deploy-web/src/queries/useManagedWalletQuery.ts	94.44% <100.00%> (ø)
...oy-web/src/services/analytics/analytics.service.ts	86.13% <ø> (ø)
...xy/src/services/ProviderService/ProviderService.ts	95.23% <100.00%> (ø)
...oy-web/src/context/PaymentPollingProvider/index.ts	0.00% <0.00%> (ø)
apps/deploy-web/src/pages/_app.tsx	0.00% <0.00%> (ø)
.../deployment-reader/db-deployment-reader.service.ts	97.10% <95.55%> (ø)
apps/deploy-web/src/hooks/useManagedWallet.ts	23.07% <0.00%> (ø)
... and 3 more

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

apps/provider-proxy/test/setup/chainApiServer.ts (1)

18-18: Good path update; prefer strict pathname check and set JSON content-type

Tighten routing and set the response header for JSON.

-      if (!req.url?.includes("/akash/cert/v1/certificates/list")) {
+      const url = new URL(`http://localhost${req.url || "/"}`);
+      if (url.pathname !== "/akash/cert/v1/certificates/list") {
         res.writeHead(404, "Not Found");
         res.end("");
         return;
       }
-
-      const url = new URL(`http://localhost${req.url || "/"}`);
+      res.setHeader("Content-Type", "application/json; charset=utf-8");

apps/provider-proxy/tsconfig.build.json (1)

6-9: Explicitly set moduleResolution and trim lib

• Add "moduleResolution": "NodeNext" alongside "module": "NodeNext" in apps/provider-proxy/tsconfig.build.json.
• You’re on TypeScript ~5.8.2, and rewriteRelativeImportExtensions has been supported since TS 5.7 (2ality.com).
• (Optional) You can simplify "lib" to just ["ESNext"].

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b888d90 and b85bee9.

📒 Files selected for processing (3)

• apps/provider-proxy/src/services/ProviderService/ProviderService.ts (1 hunks)
• apps/provider-proxy/test/setup/chainApiServer.ts (1 hunks)
• apps/provider-proxy/tsconfig.build.json (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Never use type any or cast to type any. Always define the proper TypeScript types.

Files:

• apps/provider-proxy/test/setup/chainApiServer.ts
• apps/provider-proxy/src/services/ProviderService/ProviderService.ts

**/*.{js,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

**/*.{js,ts,tsx}: Never use deprecated methods from libraries.
Don't add unnecessary comments to the code

Files:

• apps/provider-proxy/test/setup/chainApiServer.ts
• apps/provider-proxy/src/services/ProviderService/ProviderService.ts

🧬 Code graph analysis (1)

apps/provider-proxy/src/services/ProviderService/ProviderService.ts (1)

apps/provider-proxy/src/utils/retry.ts (1)

• httpRetry (4-6)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: test-build

[coderabbitai]

🛠️ Refactor suggestion | 🟠 Major

🧩 Analysis chain

Endpoint bump looks right; include 500 in retry and add a timeout

• The retry predicate skips HTTP 500 exactly. Use >= 500.
• Add an abort signal to avoid hanging fetches.

Apply:

-    const response = await httpRetry(() => this.fetch(`${baseUrl}/akash/cert/v1/certificates/list?${queryParams}`), {
-      retryIf: response => response.status > 500,
+    const response = await httpRetry(
+      () => this.fetch(`${baseUrl}/akash/cert/v1/certificates/list?${queryParams}`, { signal: AbortSignal.timeout(10_000) }),
+      {
+        retryIf: response => response.status >= 500,
         logger: this.logger
-    });
+      }
+    );

Also, per Issue #1920, please verify no lingering v1beta endpoints remain.

Run this repo scan to catch any remaining v1beta references:

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail
echo "Scanning for v1beta references…"
rg -nP -C1 --glob '!**/node_modules/**' --glob '!**/dist/**' \
  -e '/v1beta\d*/' -e '\bv1beta\b' -e '/cert/v1beta' .

Length of output: 31

---

Use AbortSignal.timeout and include HTTP 500 status in retry predicate

• Pass { signal: AbortSignal.timeout(10_000) } to the fetch call to prevent hanging requests.
• Change retryIf: response => response.status > 500 to response.status >= 500.
• No lingering v1beta endpoints remain in the codebase.

🤖 Prompt for AI Agents

In apps/provider-proxy/src/services/ProviderService/ProviderService.ts around
lines 27 to 30, the fetch call needs a request timeout and the retry predicate
should include HTTP 500; update the fetch invocation to pass an AbortSignal
created with AbortSignal.timeout(10_000) so the request cancels after 10s,
change the httpRetry option to use retryIf: response => response.status >= 500,
and scan this file (and the repo) to ensure no lingering "v1beta" Akash
endpoints remain, replacing them with the correct v1 paths if found.

[baktun14]

It should be merged in main-sdk-next?

[stalniy]

It should be merged in main-sdk-next?

yes! thanks for pointing out this!