Skip to content

fix: proxy build script#1987

Merged
baktun14 merged 2 commits intomainfrom
fix/proxy-build
Oct 1, 2025
Merged

fix: proxy build script#1987
baktun14 merged 2 commits intomainfrom
fix/proxy-build

Conversation

@baktun14
Copy link
Contributor

@baktun14 baktun14 commented Oct 1, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Corrected logging module path resolution to prevent potential import issues, improving reliability of HTTP request logging.
  • Chores

    • Updated build configuration for the provider proxy to streamline bundling with no expected runtime impact.

@baktun14 baktun14 requested a review from a team as a code owner October 1, 2025 13:06
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 1, 2025

Walkthrough

Removes the esbuild flag --packages=external from apps/provider-proxy/package.json build script and fixes misspelled import/export paths from "servicies" to "services" in packages/logging/src/hono/http-logger/http-logger.service.ts and packages/logging/src/index.ts. No public API or control flow changes.

Changes

Cohort / File(s) Summary
Build configuration
apps/provider-proxy/package.json
Removed esbuild flag --packages=external from the build script; other build options unchanged.
Logging path corrections
packages/logging/src/hono/http-logger/http-logger.service.ts, packages/logging/src/index.ts
Corrected import/export paths from servicies/... to services/...; no logic or API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • ygrishajev

Poem

A nibble of flags, a hop through the logs,
I tidy the paths where code sometimes fogs.
No functions disturbed, no APIs rearranged—
Just trails realigned, directories changed.
Thump-thump, build runs clean—carrot-approved! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title cleanly and concisely describes the primary change in this pull request, namely correcting the proxy build script in the apps/provider-proxy package, which aligns directly with the removal of the esbuild --packages=external option; it is specific without including minor auxiliary fixes.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/proxy-build

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.46%. Comparing base (f6a873c) to head (6504703).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1987      +/-   ##
==========================================
- Coverage   45.46%   45.46%   -0.01%     
==========================================
  Files        1005     1005              
  Lines       28506    28506              
  Branches     7458     7469      +11     
==========================================
- Hits        12960    12959       -1     
+ Misses      14336    14327       -9     
- Partials     1210     1220      +10     
Flag Coverage Δ *Carryforward flag
api 81.57% <ø> (-0.03%) ⬇️
deploy-web 23.82% <ø> (+<0.01%) ⬆️
log-collector 75.35% <ø> (ø)
notifications 87.94% <ø> (ø)
provider-console 81.48% <ø> (ø) Carriedforward from f1f5ef9
provider-proxy 84.98% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f6a873c and 6504703.

📒 Files selected for processing (3)
  • apps/provider-proxy/package.json (1 hunks)
  • packages/logging/src/hono/http-logger/http-logger.service.ts (1 hunks)
  • packages/logging/src/index.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Never use type any or cast to type any. Always define the proper TypeScript types.

Files:

  • packages/logging/src/index.ts
  • packages/logging/src/hono/http-logger/http-logger.service.ts
**/*.{js,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

**/*.{js,ts,tsx}: Never use deprecated methods from libraries.
Don't add unnecessary comments to the code

Files:

  • packages/logging/src/index.ts
  • packages/logging/src/hono/http-logger/http-logger.service.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: test-build
  • GitHub Check: validate / validate-app
  • GitHub Check: test-build
  • GitHub Check: validate / validate-app
  • GitHub Check: test-build
  • GitHub Check: validate / validate-app
  • GitHub Check: test-build
  • GitHub Check: test-build
  • GitHub Check: Validate local packages
🔇 Additional comments (2)
packages/logging/src/index.ts (1)

1-1: LGTM! Export path typo corrected.

The export path has been correctly updated from "servicies" to "services", fixing the typo at the package entry point. This aligns with the import path correction in packages/logging/src/hono/http-logger/http-logger.service.ts.

packages/logging/src/hono/http-logger/http-logger.service.ts (1)

3-3: LGTM! Typo in import path corrected and no remaining references to "servicies" found.

@baktun14 baktun14 merged commit 7c0a504 into main Oct 1, 2025
63 checks passed
@baktun14 baktun14 deleted the fix/proxy-build branch October 1, 2025 15:46
ygrishajev pushed a commit that referenced this pull request Oct 6, 2025
* fix: proxy build script

* fix: typo
ygrishajev pushed a commit that referenced this pull request Oct 6, 2025
* fix: proxy build script

* fix: typo
stalniy pushed a commit that referenced this pull request Nov 20, 2025
* fix: proxy build script

* fix: typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments