test: updates leap wallet fixture for web e2e and adjusts interactions#2107
Merged
ygrishajev merged 1 commit intomainfrom Oct 24, 2025
Merged
test: updates leap wallet fixture for web e2e and adjusts interactions#2107ygrishajev merged 1 commit intomainfrom
ygrishajev merged 1 commit intomainfrom
Conversation
Contributor
WalkthroughThis PR removes numerous test UI fixture files and bundled components from the Leap Cosmos extension test suite while modifying two test action files to improve flow and add assertions. Approximately 40+ fixture files are deleted, primarily minified React UI bundles used for testing wallet operations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes The PR consists primarily of homogeneous deletions of test fixture bundles with minimal logic examination required. The two modified test files contain straightforward refactorings: sequential flow adjustment with timeout change and assertion addition. While the deletion volume is large, the repetitive nature and lack of logic interdependencies reduce review complexity. Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2107 +/- ##
==========================================
- Coverage 46.12% 45.77% -0.36%
==========================================
Files 1019 1009 -10
Lines 28885 28536 -349
Branches 7555 7501 -54
==========================================
- Hits 13323 13062 -261
+ Misses 15273 14357 -916
- Partials 289 1117 +828
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (101)
apps/deploy-web/tests/ui/fixture/Leap/0275c1ae2991500f082f.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/0527ac13b30350d682d6.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/08de870199819102953a.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/0e125a893a5a5680eb7f.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/126c3b76d38d48b97af6.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/128ef0fbcdc5ba6280de.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/1858df83a1361be514ed.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/1880480282ce4191f3d8.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/1aa9de4932f7e99f5188.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/236d3f643d0b1810711e.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/31d26847bf928ce71f75.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/3787dad44cbca887784f.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/5c61ad41ae6ada104aa1.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/5e01934f4fa69e49a7b5.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/5ea44e43adb5ff99de21.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/612ba67e6e955dd2fbcb.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/761b19ece7eeef54d6f6.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/90c7aa807546cb42c2b3.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/953e7f4063386843d8d1.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/a74584141891659b1157.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/bbd36b6b9b67af3161aa.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/bd438f981b46714a684f.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/cc8ff343a061fe80efe9.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/cfbbde087923f7270858.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/d5e925ff19483d048ef2.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/e22aff60485fa8496065.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/e5479c094d5a7fc24e95.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/f2bbf6141b5ebb93dfe8.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/f9aebe0836817b57.module.wasmis excluded by!**/*.wasmapps/deploy-web/tests/ui/fixture/Leap/fdfb955455e4eb4ed556.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/icon-128.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/icon-16.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/icon-48.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/icons/icon-128.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/icons/icon-16.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/icons/icon-48.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/font/DMMono-Medium.woff2is excluded by!**/*.woff2apps/deploy-web/tests/ui/fixture/Leap/static/font/DMMono-Regular.woff2is excluded by!**/*.woff2apps/deploy-web/tests/ui/fixture/Leap/static/font/Satoshi-Black.woff2is excluded by!**/*.woff2apps/deploy-web/tests/ui/fixture/Leap/static/font/Satoshi-Bold.woff2is excluded by!**/*.woff2apps/deploy-web/tests/ui/fixture/Leap/static/font/Satoshi-Light.woff2is excluded by!**/*.woff2apps/deploy-web/tests/ui/fixture/Leap/static/font/Satoshi-Medium.woff2is excluded by!**/*.woff2apps/deploy-web/tests/ui/fixture/Leap/static/font/Satoshi-Regular.woff2is excluded by!**/*.woff2apps/deploy-web/tests/ui/fixture/Leap/static/image/bidds.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/chad-default-banner.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/chad-eligible-banner.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/chad-highlight-banner.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/circular.gifis excluded by!**/*.gifapps/deploy-web/tests/ui/fixture/Leap/static/image/compass-pin-extension.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/cosmos.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/cosmosEcosystem.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/ethereum.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/hardware-wallet-connect-usb.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/hardware-wallet-connect.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/lumi.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/lumi_cover.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/mars-airdrop-banner.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/milkyway.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/non-chad-banner.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/onboarding-sucess.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/usdc-tilted.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/image/welcome-sei-v2.pngis excluded by!**/*.pngapps/deploy-web/tests/ui/fixture/Leap/static/svg/airdropBanner.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/airdropFailed.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/airdropOver.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/archId.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/chad-star-icon.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/compass-circle.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/compass-no-stake.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/compass-reward.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/dashboard.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/faucet.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/frog-happy-with-bg.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/frog-happy.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/frog-panic.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/frog-sad.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/ibc-domains.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/icns.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/juno-swap.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/keplr.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/leap-custom-dark-mode.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/leap-custom-light-mode.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/leap-reward.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/ledger-evm-chains.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/light-node-banner.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/metamask.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/nbtc-symbol.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/no-stake.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/noble-airdrop-banner.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/nomic-fullname-logo.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/not-chad-star-icon.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/onboarding-frog.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/osmosis.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/pallet.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/pin-to-extension.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/presale.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/sei-v2.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/sns.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/space-id.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/terra-station.svgis excluded by!**/*.svgapps/deploy-web/tests/ui/fixture/Leap/static/svg/usdc-logo.svgis excluded by!**/*.svg
📒 Files selected for processing (48)
apps/deploy-web/tests/ui/actions/selectChainNetwork.ts(1 hunks)apps/deploy-web/tests/ui/disconnect-wallet.spec.ts(1 hunks)apps/deploy-web/tests/ui/fixture/Leap/1035.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/1131.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/1348.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/2127.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/283.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/2830.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/3085.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/3364.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/3470.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/3962.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/4143.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/4147.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/4259.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/4327.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/4394.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/4409.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/4703.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/4777.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/4871.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/5066.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/5069.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/5203.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/5238.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/5247.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/5292.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/5401.js.LICENSE.txt(1 hunks)apps/deploy-web/tests/ui/fixture/Leap/5435.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/5509.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/581.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/5968.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/6023.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/6412.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/6885.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/7046.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/7370.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/7395.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/7427.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/7512.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/8208.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/8295.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/8333.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/8820.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/8839.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/9148.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/963.js(0 hunks)apps/deploy-web/tests/ui/fixture/Leap/9779.js(0 hunks)
💤 Files with no reviewable changes (45)
- apps/deploy-web/tests/ui/fixture/Leap/7046.js
- apps/deploy-web/tests/ui/fixture/Leap/3364.js
- apps/deploy-web/tests/ui/fixture/Leap/2830.js
- apps/deploy-web/tests/ui/fixture/Leap/5069.js
- apps/deploy-web/tests/ui/fixture/Leap/5435.js
- apps/deploy-web/tests/ui/fixture/Leap/6023.js
- apps/deploy-web/tests/ui/fixture/Leap/5509.js
- apps/deploy-web/tests/ui/fixture/Leap/581.js
- apps/deploy-web/tests/ui/fixture/Leap/4703.js
- apps/deploy-web/tests/ui/fixture/Leap/5247.js
- apps/deploy-web/tests/ui/fixture/Leap/4871.js
- apps/deploy-web/tests/ui/fixture/Leap/4143.js
- apps/deploy-web/tests/ui/fixture/Leap/4394.js
- apps/deploy-web/tests/ui/fixture/Leap/8295.js
- apps/deploy-web/tests/ui/fixture/Leap/1035.js
- apps/deploy-web/tests/ui/fixture/Leap/9148.js
- apps/deploy-web/tests/ui/fixture/Leap/5968.js
- apps/deploy-web/tests/ui/fixture/Leap/6412.js
- apps/deploy-web/tests/ui/fixture/Leap/7427.js
- apps/deploy-web/tests/ui/fixture/Leap/2127.js
- apps/deploy-web/tests/ui/fixture/Leap/3470.js
- apps/deploy-web/tests/ui/fixture/Leap/6885.js
- apps/deploy-web/tests/ui/fixture/Leap/283.js
- apps/deploy-web/tests/ui/fixture/Leap/8208.js
- apps/deploy-web/tests/ui/fixture/Leap/7395.js
- apps/deploy-web/tests/ui/fixture/Leap/963.js
- apps/deploy-web/tests/ui/fixture/Leap/5238.js
- apps/deploy-web/tests/ui/fixture/Leap/1131.js
- apps/deploy-web/tests/ui/fixture/Leap/8839.js
- apps/deploy-web/tests/ui/fixture/Leap/7370.js
- apps/deploy-web/tests/ui/fixture/Leap/9779.js
- apps/deploy-web/tests/ui/fixture/Leap/3962.js
- apps/deploy-web/tests/ui/fixture/Leap/4259.js
- apps/deploy-web/tests/ui/fixture/Leap/4147.js
- apps/deploy-web/tests/ui/fixture/Leap/5066.js
- apps/deploy-web/tests/ui/fixture/Leap/4777.js
- apps/deploy-web/tests/ui/fixture/Leap/5292.js
- apps/deploy-web/tests/ui/fixture/Leap/4409.js
- apps/deploy-web/tests/ui/fixture/Leap/8333.js
- apps/deploy-web/tests/ui/fixture/Leap/3085.js
- apps/deploy-web/tests/ui/fixture/Leap/5203.js
- apps/deploy-web/tests/ui/fixture/Leap/8820.js
- apps/deploy-web/tests/ui/fixture/Leap/7512.js
- apps/deploy-web/tests/ui/fixture/Leap/4327.js
- apps/deploy-web/tests/ui/fixture/Leap/1348.js
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Never use type any or cast to type any. Always define the proper TypeScript types.
Files:
apps/deploy-web/tests/ui/actions/selectChainNetwork.tsapps/deploy-web/tests/ui/disconnect-wallet.spec.ts
**/*.{js,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
**/*.{js,ts,tsx}: Never use deprecated methods from libraries.
Don't add unnecessary comments to the code
Files:
apps/deploy-web/tests/ui/actions/selectChainNetwork.tsapps/deploy-web/tests/ui/disconnect-wallet.spec.ts
**/*.spec.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/no-jest-mock.mdc)
Don't use
jest.mock()to mock dependencies in test files. Instead, usejest-mock-extendedto create mocks and pass mocks as dependencies to the service under test.
**/*.spec.{ts,tsx}: Usesetupfunction instead ofbeforeEachin test files
setupfunction must be at the bottom of the rootdescribeblock in test files
setupfunction creates an object under test and returns it
setupfunction should accept a single parameter with inline type definition
Don't use shared state insetupfunction
Don't specify return type ofsetupfunction
Files:
apps/deploy-web/tests/ui/disconnect-wallet.spec.ts
🧠 Learnings (1)
📚 Learning: 2025-10-15T16:39:55.348Z
Learnt from: jzsfkzm
PR: akash-network/console#2039
File: apps/deploy-web/tests/ui/change-wallets.spec.ts:4-10
Timestamp: 2025-10-15T16:39:55.348Z
Learning: In the Akash Console E2E tests using the context-with-extension fixture, the first wallet is automatically created during fixture setup via `importWalletToLeap` in `apps/deploy-web/tests/ui/fixture/wallet-setup.ts`, so tests that call `frontPage.createWallet()` are creating a second wallet to test wallet switching functionality.
Applied to files:
apps/deploy-web/tests/ui/disconnect-wallet.spec.ts
🧬 Code graph analysis (1)
apps/deploy-web/tests/ui/disconnect-wallet.spec.ts (2)
apps/deploy-web/tests/ui/fixture/context-with-extension.ts (1)
test(12-75)apps/deploy-web/tests/ui/pages/LeapExt.tsx (1)
LeapExt(9-40)
🪛 LanguageTool
apps/deploy-web/tests/ui/fixture/Leap/5401.js.LICENSE.txt
[grammar] ~65-~65: Ensure spelling is correct
Context: ...https://feross.org/opensource / /! scure-base - MIT License (c) 2022 Paul Miller...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~67-~67: Ensure spelling is correct
Context: ...022 Paul Miller (paulmillr.com) / /! scure-bip32 - MIT License (c) 2022 Patricio P...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~69-~69: Ensure spelling is correct
Context: ...no, Paul Miller (paulmillr.com) / /! scure-bip39 - MIT License (c) 2022 Patricio P...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[uncategorized] ~208-~208: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...gned big-endian} encodings; * * 32-bit floating point values with {@link * module:Layout.f...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[uncategorized] ~211-~211: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...ig-endian} representations; * * 64-bit floating point values with {@link * module:Layout.f...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[style] ~326-~326: Using many exclamation marks might seem excessive (in this case: 20 exclamation marks for a text that’s 9480 characters long)
Context: ... THE POSSIBILITY OF SUCH DAMAGE. */ //! goToAndStop must be relative to the sta...
(EN_EXCESSIVE_EXCLAMATION)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: test-build
- GitHub Check: validate / validate-app
- GitHub Check: test-build
- GitHub Check: Validate local packages
🔇 Additional comments (2)
apps/deploy-web/tests/ui/disconnect-wallet.spec.ts (1)
1-1: LGTM! Import and formatting improvements.The addition of
expectto the import is necessary for the assertion on line 9, and the blank line improves readability by visually separating the action from the assertion.Also applies to: 8-8
apps/deploy-web/tests/ui/actions/selectChainNetwork.ts (1)
14-18: Excellent refactoring to sequential popup handling pattern.The new approach follows Playwright best practices by starting the
waitForEventlistener before triggering the action that opens the popup. This sequential pattern is more explicit and prevents potential race conditions that could occur with concurrent patterns.
stalniy
approved these changes
Oct 24, 2025
baktun14
approved these changes
Oct 24, 2025
This was referenced Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit