fix: remove stale anonymous cleaner job

[baktun14]

Summary by CodeRabbit

• Chores

  • Removed the stale anonymous users cleanup feature, including its scheduled job, CLI command, config, service, summarizer, and repository paging logic.

• Tests

  • Removed the functional test suite covering stale anonymous users cleanup.

• Bug Fixes

  • Corrected active deployments counting logic so active deployments are properly identified.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Removes the stale anonymous user cleanup feature: deletes the Helm scheduled job, CLI command, env schema and config service, controller method, repository paging method, the cleaner service and summarizer, and its functional test; also adjusts a deployment repository filter.

Changes

Cohort / File(s)	Summary
Helm Infrastructure Configuration \.helm/console-api-prod-mainnet-values.yaml``	Deleted the scheduled job definition for cleanup-stale-anonymous-users (weekly Monday 09:00 cron, command and args).
CLI Command Registration apps/api/src/console.ts	Removed the cleanup-stale-anonymous-users CLI command registration and related imports/wiring.
User Configuration apps/api/src/user/config/env.config.ts, apps/api/src/user/services/user-config/user-config.service.ts	Removed exported envSchema for STALE_ANONYMOUS_USERS_LIVE_IN_DAYS and deleted UserConfigService that used it.
Cleanup Service Layer apps/api/src/user/services/stale-anonymous-users-cleaner/..., apps/api/src/user/services/stale-anonymous-users-cleaner-summarizer/...	Deleted StaleAnonymousUsersCleanerService, its options interface, and StaleAnonymousUsersCleanerSummarizer (all logic and summary counters removed).
Controller & Data Access apps/api/src/user/controllers/user/user.controller.ts, apps/api/src/user/repositories/user/user.repository.ts	Removed UserController.cleanUpStaleAnonymousUsers and UserRepository.paginateStaleAnonymousUsers along with related imports.
Functional Tests apps/api/test/functional/stale-anonymous-users-cleanup.spec.ts	Deleted the entire functional test spec that validated stale anonymous-user cleanup scenarios.
Deployment Repository Logic apps/api/src/deployment/repositories/deployment/deployment.repository.ts	Changed countActiveByOwner filter on closedHeight from != null to == null (reversed closed/open criteria).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Scheduler as Helm Job / Cron
  participant CLI as CLI Handler
  participant Controller as UserController
  participant Cleaner as StaleAnonymousUsersCleanerService
  participant Repo as UserRepository
  participant WalletSvc as ManagedUserWalletService
  participant DB as Database

  Note over Scheduler,CLI `#D6EAF8`: (previously) scheduled cleanup run
  Scheduler->>CLI: invoke cleanup command
  CLI->>Controller: cleanUpStaleAnonymousUsers(options)
  Controller->>Cleaner: cleanUpStaleAnonymousUsers(options)
  Cleaner->>Repo: paginateStaleAnonymousUsers(inactivityDays,...)
  Repo->>DB: query stale users (paged)
  Cleaner->>WalletSvc: revoke wallets for userIds
  Cleaner->>DB: delete orphaned users
  Note right of Cleaner `#FDEBD0`: emit summary/log

Loading

(Note: the sequence represents the removed control flow; corresponding components/edges were deleted across the diff.)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Pay extra attention to:
  • Ensure no remaining references to removed services/methods (CLI, controller, DI registrations).
  • The closedHeight filter change in deployment.repository.ts — verify intended semantics and tests.
  • Deleted functional test — confirm no other tests rely on its setup utilities.

Possibly related PRs

• chore: refactor api functional tests to get rid of anonymous user #1758 — related removal/refactor of anonymous-user creation/cleanup logic and test changes.
• fix(billing): clear all anon #2257 — changes to STALE_ANONYMOUS_USERS_LIVE_IN_DAYS configuration (default adjustments), potentially overlapping with env schema removal.

Suggested reviewers

• stalniy
• ygrishajev

Poem

🐰 I hopped through code at break of day,
I nudged the cron and tucked it away,
No cleaners left to chase the stale,
Quiet fields where rabbits trail. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately describes the primary objective: removing the stale anonymous users cleaner job and all related infrastructure.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/clean-up-anon-job

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d37605f and 2993664.

📒 Files selected for processing (1)

• apps/api/src/deployment/repositories/deployment/deployment.repository.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-06-03T15:06:34.211Z

Learnt from: baktun14
Repo: akash-network/console PR: 1428
File: apps/api/src/deployment/controllers/deployment/deployment.controller.ts:0-0
Timestamp: 2025-06-03T15:06:34.211Z
Learning: The `getByOwnerAndDseq` method in `apps/api/src/deployment/controllers/deployment/deployment.controller.ts` is intentionally public without the `Protected` decorator because it serves public blockchain data from an indexer, following the pattern of public blockchain APIs.

Applied to files:

• apps/api/src/deployment/repositories/deployment/deployment.repository.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: validate / validate-app
• GitHub Check: test-build
• GitHub Check: Analyze (javascript-typescript)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

❌ 3 Tests Failed:

Tests completed	Failed	Passed	Skipped
730	3	727	0

View the top 3 failed test(s) by shortest run time

Managed Wallet API Deployment Flow should maintain read-only operations during blockchain node outages

Stack Traces | 33.5s run time

Error: expect(received).toMatchObject(expected)

Matcher error: received value must be a non-null object

Received has value: undefined
    at Object.<anonymous> (.../test/functional/managed-api-deployment-flow.spec.ts:201:21)
    at processTicksAndRejections (node:internal/process/task_queues:103:5)

Managed Wallet API Deployment Flow should execute a full deployment cycle with provider JWT auth

Stack Traces | 34.1s run time

Error: expect(received).toMatchObject(expected)

Matcher error: received value must be a non-null object

Received has value: undefined
    at .../test/functional/managed-api-deployment-flow.spec.ts:82:21
    at processTicksAndRejections (node:internal/process/task_queues:103:5)

Managed Wallet API Deployment Flow should execute a full deployment cycle with provider mTLS auth

Stack Traces | 45.2s run time

Error: expect(received).toMatchObject(expected)

Matcher error: received value must be a non-null object

Received has value: undefined
    at .../test/functional/managed-api-deployment-flow.spec.ts:82:21
    at processTicksAndRejections (node:internal/process/task_queues:103:5)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}