Skip to content

fix: removes AUTHORIZING_WALLET_MNEMONIC env var from UI tests#2292

Merged
stalniy merged 1 commit intomainfrom
fix/e2e-test-config
Dec 1, 2025
Merged

fix: removes AUTHORIZING_WALLET_MNEMONIC env var from UI tests#2292
stalniy merged 1 commit intomainfrom
fix/e2e-test-config

Conversation

@stalniy
Copy link
Contributor

@stalniy stalniy commented Dec 1, 2025

Why

because it's unused

Summary by CodeRabbit

  • Chores
    • Removed browser debugging flag from end-to-end testing workflow.
    • Removed unused field from test configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@stalniy stalniy requested a review from a team as a code owner December 1, 2025 11:44
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 1, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

These changes remove test configuration settings: eliminating the AUTHORIZING_WALLET_MNEMONIC environment variable requirement from the test environment schema and removing the DEBUG: "pw:browser" flag from the GitHub Actions e2e testing workflow step.

Changes

Cohort / File(s) Summary
GitHub Actions workflow configuration
\.github/actions/console-web-ui-testing/action\.yml
Removed the DEBUG: "pw:browser" environment variable from the Run e2e tests step
Test environment configuration
apps/deploy-web/tests/ui/fixture/test-env\.config\.ts
Removed AUTHORIZING_WALLET_MNEMONIC field from testEnvSchema and its corresponding entry from testEnvConfig.parse input

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple removal of two configuration fields with no logic changes
  • Changes are isolated to configuration/setup files
  • No functional impact on core logic

Possibly related PRs

Suggested reviewers

  • ygrishajev

Poem

🐰 Debug flags hop away, wallets fade to gray,
Configuration shrinks with each line we stray,
Cleaner schemas bloom where clutter used to stay,
Tests run swift and light—hurrah, hooray! 🌿

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/e2e-test-config

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef2fcc3 and b3480d0.

📒 Files selected for processing (2)
  • .github/actions/console-web-ui-testing/action.yml (0 hunks)
  • apps/deploy-web/tests/ui/fixture/test-env.config.ts (0 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@stalniy stalniy merged commit 1e0826d into main Dec 1, 2025
44 of 45 checks passed
@stalniy stalniy deleted the fix/e2e-test-config branch December 1, 2025 11:44
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.28%. Comparing base (ef2fcc3) to head (b3480d0).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2292      +/-   ##
==========================================
- Coverage   47.61%   47.28%   -0.34%     
==========================================
  Files        1036     1026      -10     
  Lines       29357    29008     -349     
  Branches     7581     7540      -41     
==========================================
- Hits        13978    13715     -263     
+ Misses      14891    14805      -86     
  Partials      488      488              
Flag Coverage Δ *Carryforward flag
api 81.84% <ø> (ø) Carriedforward from ef2fcc3
deploy-web 26.42% <ø> (ø) Carriedforward from ef2fcc3
log-collector ?
notifications 87.94% <ø> (ø) Carriedforward from ef2fcc3
provider-console 81.48% <ø> (ø) Carriedforward from ef2fcc3
provider-proxy 84.35% <ø> (ø) Carriedforward from ef2fcc3

*This pull request uses carry forward flags. Click here to find out more.
see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments