Skip to content

chore: fixes prerelease PR#2575

Merged
stalniy merged 1 commit intomainfrom
chore/fix-prerelease-pr
Jan 28, 2026
Merged

chore: fixes prerelease PR#2575
stalniy merged 1 commit intomainfrom
chore/fix-prerelease-pr

Conversation

@stalniy
Copy link
Contributor

@stalniy stalniy commented Jan 28, 2026

Why

bug in package-lock updating logic.

Summary by CodeRabbit

  • Chores
    • Consolidated release generation into a single, configurable flow to improve consistency and efficiency.
    • Switched to iterating over a specified set of packages for releases instead of running each release separately.
    • Limited package-lock updates and related error handling to only the selected packages, reducing unnecessary changes.

✏️ Tip: You can customize this high-level summary in your review settings.

@stalniy stalniy requested a review from a team as a code owner January 28, 2026 00:18
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

Introduces PACKAGES_TO_RELEASE and replaces multiple explicit npm run release invocations with a loop in the CI workflow; the inline Node.js script now filters package-lock.json updates to only packages listed in PACKAGES_TO_RELEASE.

Changes

Cohort / File(s) Summary
Release Workflow Refactor
.github/workflows/create-pre-release-pr.yml
Added PACKAGES_TO_RELEASE env var; replaced individual npm run release calls with a loop that iterates over the comma-separated packages and runs npm release per package; updated inline Node.js script to derive packagesToRelease from process.env and restrict package-lock.json processing to that subset.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • ygrishajev
  • baktun14

Poem

🐰 A loop hops through packages, one by one,
No scattered calls beneath the CI sun.
PACKAGES_TO_RELEASE guides each small race,
Tidy locks updated in their proper place. 🥕🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'chore: fixes prerelease PR' is vague and generic, using non-descriptive language that doesn't clearly convey what the specific change addresses. Make the title more specific by describing the actual issue being fixed, such as 'chore: fix package-lock.json filtering in prerelease workflow' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In @.github/workflows/create-pre-release-pr.yml:
- Around line 96-102: The PACKAGES_TO_RELEASE split produces entries with
leading/trailing spaces so includes(pkgName) misses matches; update the code
that creates packagesToRelease (the variable used in the includes check) to trim
whitespace from each split entry (and optionally filter out empty strings)
before using it in Object.entries(lockfile.packages).forEach so the
includes(pkgName) check correctly matches package names and pkg.version
assignments run as expected.
- Around line 79-92: The folded YAML leaves leading spaces in
PACKAGES_TO_RELEASE entries so workspace names like " apps/deploy-web" fail;
update the run loop that reads PACKAGES_TO_RELEASE to trim whitespace and skip
empty lines before calling npm run release -w: after reading each package in the
while loop (refer to PACKAGES_TO_RELEASE and the npm run release -w invocation),
strip leading/trailing whitespace from the package variable (e.g., via parameter
expansion or an appropriate trim command) and skip iteration if the resulting
string is empty, then call npm run release with the trimmed package name.

@stalniy stalniy enabled auto-merge January 28, 2026 10:59
@stalniy stalniy disabled auto-merge January 28, 2026 10:59
@stalniy stalniy enabled auto-merge January 28, 2026 10:59
@stalniy stalniy disabled auto-merge January 28, 2026 11:05
@stalniy stalniy enabled auto-merge January 28, 2026 11:05
@stalniy stalniy disabled auto-merge January 28, 2026 11:11
@stalniy stalniy enabled auto-merge January 28, 2026 11:13
@stalniy stalniy disabled auto-merge January 28, 2026 11:13
@stalniy stalniy enabled auto-merge January 28, 2026 11:13
@stalniy stalniy disabled auto-merge January 28, 2026 11:13
@stalniy stalniy enabled auto-merge January 28, 2026 11:13
@stalniy stalniy force-pushed the chore/fix-prerelease-pr branch from 923d83c to 651f94f Compare January 28, 2026 11:15
@stalniy stalniy disabled auto-merge January 28, 2026 11:15
@stalniy stalniy enabled auto-merge January 28, 2026 11:16
@stalniy stalniy disabled auto-merge January 28, 2026 11:17
@stalniy stalniy enabled auto-merge January 28, 2026 11:18
@stalniy stalniy disabled auto-merge January 28, 2026 11:18
@stalniy stalniy enabled auto-merge January 28, 2026 11:18
@stalniy stalniy disabled auto-merge January 28, 2026 11:23
@stalniy stalniy enabled auto-merge January 28, 2026 11:23
@stalniy stalniy disabled auto-merge January 28, 2026 11:24
@stalniy stalniy enabled auto-merge January 28, 2026 11:24
@stalniy stalniy disabled auto-merge January 28, 2026 11:25
@stalniy stalniy added this pull request to the merge queue Jan 28, 2026
@stalniy stalniy removed this pull request from the merge queue due to a manual request Jan 28, 2026
@stalniy stalniy added this pull request to the merge queue Jan 28, 2026
@stalniy stalniy removed this pull request from the merge queue due to a manual request Jan 28, 2026
@stalniy stalniy added this pull request to the merge queue Jan 28, 2026
@stalniy stalniy removed this pull request from the merge queue due to a manual request Jan 28, 2026
@stalniy stalniy added this pull request to the merge queue Jan 28, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 28, 2026
@stalniy stalniy merged commit c741842 into main Jan 28, 2026
69 checks passed
@stalniy stalniy deleted the chore/fix-prerelease-pr branch January 28, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments