Conversation
Contributor
📝 WalkthroughWalkthroughIntroduces Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.github/workflows/create-pre-release-pr.yml:
- Around line 96-102: The PACKAGES_TO_RELEASE split produces entries with
leading/trailing spaces so includes(pkgName) misses matches; update the code
that creates packagesToRelease (the variable used in the includes check) to trim
whitespace from each split entry (and optionally filter out empty strings)
before using it in Object.entries(lockfile.packages).forEach so the
includes(pkgName) check correctly matches package names and pkg.version
assignments run as expected.
- Around line 79-92: The folded YAML leaves leading spaces in
PACKAGES_TO_RELEASE entries so workspace names like " apps/deploy-web" fail;
update the run loop that reads PACKAGES_TO_RELEASE to trim whitespace and skip
empty lines before calling npm run release -w: after reading each package in the
while loop (refer to PACKAGES_TO_RELEASE and the npm run release -w invocation),
strip leading/trailing whitespace from the package variable (e.g., via parameter
expansion or an appropriate trim command) and skip iteration if the resulting
string is empty, then call npm run release with the trimmed package name.
ygrishajev
approved these changes
Jan 28, 2026
923d83c to
651f94f
Compare
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
bug in package-lock updating logic.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.