fix: moves amplitude on a separate subdomain#2652
Conversation
📝 WalkthroughWalkthroughEnvironment variable NEXT_PUBLIC_AMPLITUDE_PROXY_URL was changed from a relative path to an absolute HTTPS URL pointing to an external amplitude proxy endpoint. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
f31a481 to
5988cb2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/deploy-web/env/.env`:
- Line 37: The environment variable NEXT_PUBLIC_AMPLITUDE_PROXY_URL has
surrounding double quotes which trigger dotenv-linter and may be interpreted as
literal characters; update the .env entry for NEXT_PUBLIC_AMPLITUDE_PROXY_URL to
remove the surrounding quotes so the value is an unquoted URL (e.g.,
NEXT_PUBLIC_AMPLITUDE_PROXY_URL=https://console-proxy.akash.network/collect).
| SENTRY_PROJECT=deploy-web | ||
|
|
||
| NEXT_PUBLIC_AMPLITUDE_PROXY_URL="/api/collect" | ||
| NEXT_PUBLIC_AMPLITUDE_PROXY_URL="https://console-proxy.akash.network/collect" |
There was a problem hiding this comment.
Remove quotes to satisfy dotenv-linter and avoid literal quotes in value.
The linter flags this line for quote characters; some parsers treat quotes as part of the value. Use an unquoted URL unless you intentionally need quotes.
💡 Proposed change
-NEXT_PUBLIC_AMPLITUDE_PROXY_URL="https://console-proxy.akash.network/collect"
+NEXT_PUBLIC_AMPLITUDE_PROXY_URL=https://console-proxy.akash.network/collect📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| NEXT_PUBLIC_AMPLITUDE_PROXY_URL="https://console-proxy.akash.network/collect" | |
| NEXT_PUBLIC_AMPLITUDE_PROXY_URL=https://console-proxy.akash.network/collect |
🧰 Tools
🪛 dotenv-linter (4.0.0)
[warning] 37-37: [QuoteCharacter] The value has quote characters (', ")
(QuoteCharacter)
🤖 Prompt for AI Agents
In `@apps/deploy-web/env/.env` at line 37, The environment variable
NEXT_PUBLIC_AMPLITUDE_PROXY_URL has surrounding double quotes which trigger
dotenv-linter and may be interpreted as literal characters; update the .env
entry for NEXT_PUBLIC_AMPLITUDE_PROXY_URL to remove the surrounding quotes so
the value is an unquoted URL (e.g.,
NEXT_PUBLIC_AMPLITUDE_PROXY_URL=https://console-proxy.akash.network/collect).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2652 +/- ##
==========================================
- Coverage 51.37% 50.61% -0.76%
==========================================
Files 1053 1018 -35
Lines 29581 28750 -831
Branches 6611 6538 -73
==========================================
- Hits 15198 14553 -645
+ Misses 13987 13810 -177
+ Partials 396 387 -9
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Why
It's easier than fighting with nginx-ingress configs to not send some headers
Summary by CodeRabbit