Skip to content

fix: moves amplitude on a separate subdomain#2652

Merged
stalniy merged 1 commit intomainfrom
fix/deploy-web-amplitude
Feb 2, 2026
Merged

fix: moves amplitude on a separate subdomain#2652
stalniy merged 1 commit intomainfrom
fix/deploy-web-amplitude

Conversation

@stalniy
Copy link
Contributor

@stalniy stalniy commented Feb 2, 2026

Why

It's easier than fighting with nginx-ingress configs to not send some headers

Summary by CodeRabbit

  • Chores
    • Updated analytics proxy configuration to use an external HTTPS endpoint for data collection instead of a local-relative path.
    • No other configuration or application behavior changes included; analytics routing is now directed to the specified external service endpoint.

@stalniy stalniy requested a review from a team as a code owner February 2, 2026 14:55
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

Environment variable NEXT_PUBLIC_AMPLITUDE_PROXY_URL was changed from a relative path to an absolute HTTPS URL pointing to an external amplitude proxy endpoint.

Changes

Cohort / File(s) Summary
Environment Configuration
apps/deploy-web/env/.env
Updated NEXT_PUBLIC_AMPLITUDE_PROXY_URL value from "/api/collect" to "https://console-proxy.akash.network/collect".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • ygrishajev
  • baktun14

Poem

🐰 I hopped a little env line today,
From local path I leapt away,
To HTTPS fields where data sings,
A shiny proxy on my wings 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: moving Amplitude to a separate subdomain, which is exactly what the PR accomplishes by changing the NEXT_PUBLIC_AMPLITUDE_PROXY_URL to an absolute HTTPS URL pointing to a separate domain.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/deploy-web-amplitude

Comment @coderabbitai help to get the list of available commands and usage tips.

@stalniy stalniy force-pushed the fix/deploy-web-amplitude branch from f31a481 to 5988cb2 Compare February 2, 2026 14:57
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@apps/deploy-web/env/.env`:
- Line 37: The environment variable NEXT_PUBLIC_AMPLITUDE_PROXY_URL has
surrounding double quotes which trigger dotenv-linter and may be interpreted as
literal characters; update the .env entry for NEXT_PUBLIC_AMPLITUDE_PROXY_URL to
remove the surrounding quotes so the value is an unquoted URL (e.g.,
NEXT_PUBLIC_AMPLITUDE_PROXY_URL=https://console-proxy.akash.network/collect).

SENTRY_PROJECT=deploy-web

NEXT_PUBLIC_AMPLITUDE_PROXY_URL="/api/collect"
NEXT_PUBLIC_AMPLITUDE_PROXY_URL="https://console-proxy.akash.network/collect"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove quotes to satisfy dotenv-linter and avoid literal quotes in value.

The linter flags this line for quote characters; some parsers treat quotes as part of the value. Use an unquoted URL unless you intentionally need quotes.

💡 Proposed change
-NEXT_PUBLIC_AMPLITUDE_PROXY_URL="https://console-proxy.akash.network/collect"
+NEXT_PUBLIC_AMPLITUDE_PROXY_URL=https://console-proxy.akash.network/collect
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
NEXT_PUBLIC_AMPLITUDE_PROXY_URL="https://console-proxy.akash.network/collect"
NEXT_PUBLIC_AMPLITUDE_PROXY_URL=https://console-proxy.akash.network/collect
🧰 Tools
🪛 dotenv-linter (4.0.0)

[warning] 37-37: [QuoteCharacter] The value has quote characters (', ")

(QuoteCharacter)

🤖 Prompt for AI Agents
In `@apps/deploy-web/env/.env` at line 37, The environment variable
NEXT_PUBLIC_AMPLITUDE_PROXY_URL has surrounding double quotes which trigger
dotenv-linter and may be interpreted as literal characters; update the .env
entry for NEXT_PUBLIC_AMPLITUDE_PROXY_URL to remove the surrounding quotes so
the value is an unquoted URL (e.g.,
NEXT_PUBLIC_AMPLITUDE_PROXY_URL=https://console-proxy.akash.network/collect).

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.61%. Comparing base (8ea2e41) to head (5988cb2).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2652      +/-   ##
==========================================
- Coverage   51.37%   50.61%   -0.76%     
==========================================
  Files        1053     1018      -35     
  Lines       29581    28750     -831     
  Branches     6611     6538      -73     
==========================================
- Hits        15198    14553     -645     
+ Misses      13987    13810     -177     
+ Partials      396      387       -9     
Flag Coverage Δ *Carryforward flag
api 78.32% <ø> (ø) Carriedforward from 8ea2e41
deploy-web 32.76% <ø> (ø)
log-collector ?
notifications 87.94% <ø> (ø) Carriedforward from 8ea2e41
provider-console 81.48% <ø> (ø) Carriedforward from 8ea2e41
provider-proxy 84.35% <ø> (ø) Carriedforward from 8ea2e41
tx-signer ?

*This pull request uses carry forward flags. Click here to find out more.
see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stalniy stalniy merged commit 411a48a into main Feb 2, 2026
72 checks passed
@stalniy stalniy deleted the fix/deploy-web-amplitude branch February 2, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments