Conversation
📝 WalkthroughWalkthroughRelease workflows were updated to make Changes
Sequence Diagram(s)sequenceDiagram
participant CallerWorkflow as "Service Release Workflow\n(e.g. console-api-release)"
participant ReusableSetup as "reusable-deploy-setup\n(action run)"
participant DeployJobs as "Deploy Jobs\n(deploy-beta/deploy-prod)"
CallerWorkflow->>ReusableSetup: with app:<service>, image_tag:${{ inputs.image_tag || github.ref_name }}
Note right of ReusableSetup: Parse TAG_NAME -> package_name, version\nValidate tag (v*, numeric, or package==APP)
ReusableSetup-->>CallerWorkflow: outputs.image_tag (computed/validated)
CallerWorkflow->>DeployJobs: start deploy jobs using needs.setup.outputs.image_tag
DeployJobs-->>CallerWorkflow: deployment progress/results
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/reusable-deploy-setup.yml (1)
38-41:⚠️ Potential issue | 🟠 MajorRemove or use
package_nameto clear shellcheck SC2034.The variable is unused and currently fails linting.
✅ Suggested fix
- package_name="${tag%%/*}"
🤖 Fix all issues with AI agents
In @.github/workflows/provider-proxy-release.yml:
- Around line 11-15: The setup step passes an undefined input "app" to the
reusable workflow; either add an "app" input definition to the reusable workflow
file (./.github/workflows/reusable-deploy-setup.yml) or remove the "app:
provider-proxy" line from this workflow's setup invocation. Locate the setup
invocation (uses: ./.github/workflows/reusable-deploy-setup.yml) and either (A)
add a matching inputs.app entry in reusable-deploy-setup.yml so it accepts and
uses the app value, or (B) delete the "app: provider-proxy" parameter here if
the reusable workflow does not require it.
In @.github/workflows/reusable-deploy-setup.yml:
- Around line 24-35: Declare the missing workflow input "app" under
workflow_call (add inputs.app with description, required: true and type: string
alongside inputs.image_tag) and fix the conditional by wrapping the expression
in the GitHub Actions expression syntax (${ { ... } }) so the if becomes if: ${{
!startsWith(inputs.image_tag, format('{0}/v', inputs.app)) }}; ensure you
reference the existing inputs.image_tag and inputs.app names exactly and keep
the validation shell script unchanged.
f9acb63 to
88d48d9
Compare
Why
because currently release trigger deployment with invalid app version
Summary by CodeRabbit