Skip to content

feat: add --no-github flag to disable GitHub operations#163

Merged
akashgit merged 1 commit into
akashgit:mainfrom
lukeinglis:feat/no-github-flag
May 2, 2026
Merged

feat: add --no-github flag to disable GitHub operations#163
akashgit merged 1 commit into
akashgit:mainfrom
lukeinglis:feat/no-github-flag

Conversation

@lukeinglis
Copy link
Copy Markdown
Collaborator

Summary

  • Adds --no-github CLI flag to ceo, run, and tmux subcommands
  • When set, injects a directive into the CEO task to skip GitHub issue/PR creation, pushing, and cloning
  • Threads the flag through the full call chain: cmd_ceo/cmd_run -> _run_single_cycle -> _build_ceo_task -> _chain_modes
  • Includes tmux support (forwarded via shell command string), addressing the review feedback on the previous attempt (feat: add --no-github flag to disable GitHub operations #124)

Changes

Single file: factory/cli.py

  1. Argparse: --no-github added to all three subcommand parsers (ceo, run, tmux)
  2. Extraction: getattr(args, "no_github", False) in cmd_ceo and cmd_run
  3. Task injection: _build_ceo_task() appends a "GitHub Operations Disabled" directive when flag is set
  4. Threading: _run_single_cycle() and _chain_modes() accept and forward no_github
  5. tmux forwarding: cmd_tmux() appends --no-github to the shell command passed to the tmux session

Context

Supersedes #124, which was missing tmux subcommand support (flagged in review by @akashgit). This PR addresses that gap.

Fixes #122, closes #123

Test plan

  • factory ceo --help shows --no-github
  • factory run --help shows --no-github
  • factory tmux --help shows --no-github
  • Flag injects directive into CEO task string
  • No directive when flag is absent (default behavior unchanged)
  • tmux forwards flag to underlying factory run command

Add --no-github CLI flag to ceo, run, and tmux subcommands. When set,
injects a directive into the CEO task instructing it to skip all GitHub
operations (issue creation, PR posting, pushing, cloning).

The flag threads through the full call chain: cmd_ceo/cmd_run ->
_run_single_cycle -> _build_ceo_task, and through _chain_modes for
multi-step pipelines. The tmux subcommand forwards it to the underlying
factory run shell command.

Fixes akashgit#122, closes akashgit#123

Signed-off-by: Luke Inglis <lukeinglis21@yahoo.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.20%. Comparing base (d556bbb) to head (54c852e).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
factory/cli.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   86.23%   86.20%   -0.03%     
==========================================
  Files          45       45              
  Lines        6307     6316       +9     
==========================================
+ Hits         5439     5445       +6     
- Misses        868      871       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Owner

@akashgit akashgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean implementation: --no-github threads correctly through all paths (ceo, run, tmux, _run_single_cycle, _build_ceo_task, _chain_modes). 19 tests added covering parser defaults, task injection, tmux forwarding, and e2e. Lint clean, all 143 tests pass. Ship it.

@akashgit akashgit merged commit 8fea873 into akashgit:main May 2, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add --no-github flag to disable GitHub operations Discover mode creates issues on the github repo

2 participants