This repository was archived by the owner on Jun 22, 2022. It is now read-only.
fix: WebView crashing on Android 5#125
Merged
akexorcist merged 2 commits intoakexorcist:fix-web-view-crashingfrom Dec 21, 2021
Merged
fix: WebView crashing on Android 5#125akexorcist merged 2 commits intoakexorcist:fix-web-view-crashingfrom
akexorcist merged 2 commits intoakexorcist:fix-web-view-crashingfrom
Conversation
*BREAKING CHANGES* - change `targetSdkVersion` from 30 to 31 - change `appcompat` version to `1.4.0`
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API Changes
open fun delegateBaseContext(context: Context)method toLocalizationActivity. This method should allow a custom activity to wrap localized base context with other API e.g. ViewPump. This should fix LocalizationActivity >= 1.2.6 does not work with ViewPump #116delegateBaseContext(context: Context)returnslocalizationDelegate.attachBaseContext(context).applyOverrideConfiguration, IMO, is no longer needed as its solution is recommended in https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/NightModeCustomAttachBaseContextActivity.javaBREAKING CHANGES
targetSdkVersionfrom 30 to 31appcompatversion to1.4.0Note
I have locally tested instrument tests on Android 4.4 (sdk 19), Android 5 (sdk 21) and Android 9 (sdk 28) devices. Please run your CI after merging this PR to
fix-web-view-crashingbranch since the CI only runs when PR tomaster.