Fix, simplify, and improve navigation between conflicts #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigation between conflicts does not feel natural.
Namely, the issues are
GitConflictNextdoes not navigate to the next conflict.GitConflictPreviousis called, the cursor does not jump to the start of the current conflict (the "<<<<<<<" line).GitConflictPreviousis called, or the cursor is on the last conflict of a file andGitConflictNextis called, the cursor does not wrap around to the last conflict or first conflict, respectively.We can resolve these by simplifying the comparator functions in
find_next()andfind_previous().