Open
Conversation
Owner
|
Thanks! I merged other pull requset #16 now. let ctermbg_str = matchstr(sign_col, 'ctermbg=\d')I think I prefer this one. What do you think? |
Author
|
Indeed, this looks easier. Though, according to documentation ctermbg accepts named colours so it won't work at least for some valid values. |
Owner
|
The :hi Comment ctermbg=Cyan
:hi Comment
" => Comment xxx ctermbg=14As for :hi Comment guibg=Blue
:hi Comment
" => Comment xxx guibg=Blue
:hi Comment guibg=#0000FF
:hi Comment
" => Comment xxx guibg=#0000FFIn order to merge automatically, can you reset only |
Previous code set some expectations on the highlight command output which not
always are true. It exptected `ctermbg` to be exactly 3 chars long and `guibg`
to be exactly 7 chars long. This is not true for many cases. Here's for example
my `SingColumn`:
SignColumn xxx term=standout ctermfg=11 ctermbg=8 guifg=Cyan guibg=Grey
New code sets a different sets of expectations that might be a bit better. New
code relies on the normalized output of `highlight` command. It parses output
and takes the part from "=" to the first space. This should cover the case of
varying length of numeric colours as well as named colours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code set some expectations on the highlight command output which not
always are true. It exptected
ctermbgto be exactly 3 chars long andguibgto be exactly 7 chars long. This is not true for many cases. Here's for example
my
SingColumn:New code sets a different sets of expectations that might be a bit better. New
code relies on the normalized output of
highlightcommand. It parses outputand takes the part from "=" to the first space. This should cover the case of
varying length of numeric colours as well as named colours.