Ruby3 complete support#3
Merged
Merged
Conversation
Contributor
Author
|
@akira Can you please merge and release this to rubygems? We need this change in ! Thank you |
Owner
|
Thanks for the PR 👍 Just published to Rubygems v0.2.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still on the testing phase, I wonder why all the test pass without this change.
But my app fails if I don't have this change.
After upgrading my rails7 app from ruby 2.7 to 3.0
It's OK if you hold on before merging.
I've added simplecov to watch for current coverage and set the minimum to the current value, so it does not decrease in the future.