Skip to content

Corrected lut mode#7

Merged
akx merged 3 commits intoakx:parametrize-lut-testsfrom
radarhere:parametrize-lut-tests
Aug 7, 2024
Merged

Corrected lut mode#7
akx merged 3 commits intoakx:parametrize-lut-testsfrom
radarhere:parametrize-lut-tests

Conversation

@radarhere
Copy link
Copy Markdown

Suggestions for python-pillow#8290

Copy link
Copy Markdown
Owner

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somewhat disagree with the parametrize string mode – I think separate parameters are easier to visually grep, and that's what I'm used to :)

But that's fine.

@akx akx merged commit a06529a into akx:parametrize-lut-tests Aug 7, 2024
@radarhere radarhere deleted the parametrize-lut-tests branch August 7, 2024 09:14
@akx
Copy link
Copy Markdown
Owner

akx commented Aug 7, 2024

@radarhere Btw, according to https://docs.astral.sh/ruff/rules/pytest-parametrize-names-wrong-type/ both styles are being used in Pillow right now. csv style overwhelmingly more, but there are some tuple cases too.

(See: python-pillow#8295)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants