Adds API support for detecting server timeouts#12
Open
nugget wants to merge 2 commits intoalaingilbert:masterfrom
Open
Adds API support for detecting server timeouts#12nugget wants to merge 2 commits intoalaingilbert:masterfrom
nugget wants to merge 2 commits intoalaingilbert:masterfrom
Conversation
Adds new callback hook `OnTimeout` to the API which will watch the internal `lastActivity` timestamp and emit a callback if no activity has been seen recently. Also adds a helper `GetTimeoutInfo` method to the API to allow code to inspect and evaluate current heartbeat and activity data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm having a problem recently where my bots will stop seeing updates from the server, but don't realize they are disconnected. This PR adds a new callback hook
OnTimeoutto the API which will watch the internallastActivitytimestamp and emit a callback if no activity has been seen recently. Also adds a helperGetTimeoutInfomethod to the API to allow code to inspect and evaluate current heartbeat and activity data.I tried to match your code style as best I could. Happy to tweak or make adjustments if you think there's a cleaner way to implement this.