Conversation
WalkthroughDocumentation update to the upgrade guide adding Pre-Upgrade and Post-Upgrade operation sections. Version constants bumped from 1.4/1.5 to 1.5/2.0. New sections detail stopping InferenceServices before upgrade and updating them post-upgrade, with step-by-step YAML and CLI examples provided. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/en/upgrade/upgrade-from-previous-version.mdx (1)
36-40: Clarify how to identify stopped inference services.The instruction tells users to list all inference services, but doesn't explain how to determine which ones are in a "stopped" state from the command output. Users need to know what field, status, or condition to look for.
Consider adding guidance such as filtering by a specific status column or label, for example:
1. List all inference services that are currently stopped: ```bash kubectl get inferenceservices --all-namespaces ``` + + Look for services where the `READY` column shows `False` and replicas are scaled to zero, or check for services that were previously stopped via your platform's UI.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/en/upgrade/upgrade-from-previous-version.mdx` around lines 36 - 40, The docs step shows how to list inference services but doesn't explain how to spot "stopped" services; update the text near the `kubectl get inferenceservices --all-namespaces` example to tell users which fields to inspect (e.g., check the READY column for `False`, check the REPLICAS column for `0`, and/or examine STATUS or conditions for `ScaledDown`/`NotReady`), and add an alternative suggestion to run `kubectl describe inferenceservice <name>` or filter by status/label if they need more detail.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/en/upgrade/upgrade-from-previous-version.mdx`:
- Around line 36-40: The docs step shows how to list inference services but
doesn't explain how to spot "stopped" services; update the text near the
`kubectl get inferenceservices --all-namespaces` example to tell users which
fields to inspect (e.g., check the READY column for `False`, check the REPLICAS
column for `0`, and/or examine STATUS or conditions for
`ScaledDown`/`NotReady`), and add an alternative suggestion to run `kubectl
describe inferenceservice <name>` or filter by status/label if they need more
detail.
Deploying alauda-ai with
|
| Latest commit: |
9603277
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b1702f57.alauda-ai.pages.dev |
| Branch Preview URL: | https://upgrade-ai-1-5-to-2-0.alauda-ai.pages.dev |
Summary by CodeRabbit