Merged
Conversation
|
Caution Review failedFailed to post review comments WalkthroughRemoves the old AI 1.3→1.4 upgrade guide and adds a new upgrade guide for 1.4→1.5; concurrently adds and updates many documentation pages across fine‑tuning, pre‑training, kueue, installation, monitoring, model inference, workbench, and public workspace manifests, plus site/version bumps and config tweaks. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/test-pass |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@docs/en/upgrade/upgrade-from-previous-version.mdx`:
- Around line 55-57: The admonition block using :::info contains extra leading
spaces that cause its inner text to render as a code block; locate the :::info
block (the line starting with ":::info") and left-align the inner sentence "Once
the new version is uploaded and recognized by the platform, an upgrade prompt
will appear at the top of the operator's page." so it has no extra indentation
relative to :::info, then ensure the block is properly closed with ::: on its
own line; also remove any leading backticks or fences inside that block if
present.
- Around line 62-73: The text has grammar errors and mismatched casing with the
sample output; update the sentence that references the AmlCluster resource and
the expected output to read: "Check the status field of the AmlCluster resource
named `default` by running `kubectl get amlcluster default`." Then adjust the
expectation sentence to match the sample output headers and values exactly, for
example: "The output should show READY and REASON columns, e.g. `default True
Succeeded`." Ensure you reference `AmlCluster`, the command `kubectl get
amlcluster default`, and the sample output headers `READY` and `REASON`.
- Around line 75-86: The text and sample output for the KnativeServing resource
named `default-knative-serving` disagree (text says `InstallSuccessful` while
sample shows `UpgradeSuccessful`) and the sentence has a grammar error; update
the descriptive sentence to match the sample output by replacing
`InstallSuccessful` with `UpgradeSuccessful` and fix the grammar to "Should
return `UpgradeSuccessful`" (refer to the `KnativeServing` example and the line
mentioning `default-knative-serving` to locate the change).
Comment on lines
+55
to
+57
| :::info | ||
| Once the new version is uploaded and recognized by the platform, an upgrade prompt will appear at the top of the operator's page. | ||
| ::: |
There was a problem hiding this comment.
Fix admonition content indentation to avoid code-block rendering.
The extra indentation inside the :::info block likely renders as a code block in MDX.
✂️ Suggested formatting fix
:::info
- Once the new version is uploaded and recognized by the platform, an upgrade prompt will appear at the top of the operator's page.
+Once the new version is uploaded and recognized by the platform, an upgrade prompt will appear at the top of the operator's page.
:::📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| :::info | |
| Once the new version is uploaded and recognized by the platform, an upgrade prompt will appear at the top of the operator's page. | |
| ::: | |
| :::info | |
| Once the new version is uploaded and recognized by the platform, an upgrade prompt will appear at the top of the operator's page. | |
| ::: |
🤖 Prompt for AI Agents
In `@docs/en/upgrade/upgrade-from-previous-version.mdx` around lines 55 - 57, The
admonition block using :::info contains extra leading spaces that cause its
inner text to render as a code block; locate the :::info block (the line
starting with ":::info") and left-align the inner sentence "Once the new version
is uploaded and recognized by the platform, an upgrade prompt will appear at the
top of the operator's page." so it has no extra indentation relative to :::info,
then ensure the block is properly closed with ::: on its own line; also remove
any leading backticks or fences inside that block if present.
Comment on lines
+62
to
+73
| Check the status field from the `AmlCluster` resource which named `default`: | ||
|
|
||
| ```bash | ||
| kubectl get amlcluster default | ||
| ``` | ||
|
|
||
| Should returns `Ready`: | ||
|
|
||
| ``` | ||
| NAME READY REASON | ||
| default True Succeeded | ||
| ``` |
There was a problem hiding this comment.
Tighten grammar and align text with the sample output.
There are grammar issues (“which named”, “Should returns”) and the text says “Ready” while the sample shows READY/REASON.
✏️ Suggested wording
-Check the status field from the `AmlCluster` resource which named `default`:
+Check the status field of the `AmlCluster` resource named `default`:
-Should returns `Ready`:
+It should show `READY=True` and `REASON=Succeeded`:🤖 Prompt for AI Agents
In `@docs/en/upgrade/upgrade-from-previous-version.mdx` around lines 62 - 73, The
text has grammar errors and mismatched casing with the sample output; update the
sentence that references the AmlCluster resource and the expected output to
read: "Check the status field of the AmlCluster resource named `default` by
running `kubectl get amlcluster default`." Then adjust the expectation sentence
to match the sample output headers and values exactly, for example: "The output
should show READY and REASON columns, e.g. `default True Succeeded`."
Ensure you reference `AmlCluster`, the command `kubectl get amlcluster default`,
and the sample output headers `READY` and `REASON`.
Comment on lines
+75
to
+86
| Check the status field from the `KnativeServing` resource which named `default-knative-serving`: | ||
|
|
||
| ```bash | ||
| kubectl get KnativeServing.components.aml.dev default-knative-serving | ||
| ``` | ||
|
|
||
| Should returns `InstallSuccessful`: | ||
|
|
||
| ``` | ||
| NAME DEPLOYED REASON | ||
| default-knative-serving True UpgradeSuccessful | ||
| ``` |
There was a problem hiding this comment.
Resolve mismatch between expected reason text and sample output.
The text says InstallSuccessful, but the sample output shows UpgradeSuccessful. Align one of them, and fix grammar.
✏️ Suggested wording (matching the sample)
-Check the status field from the `KnativeServing` resource which named `default-knative-serving`:
+Check the status field of the `KnativeServing` resource named `default-knative-serving`:
-Should returns `InstallSuccessful`:
+It should show `DEPLOYED=True` and `REASON=UpgradeSuccessful`:🤖 Prompt for AI Agents
In `@docs/en/upgrade/upgrade-from-previous-version.mdx` around lines 75 - 86, The
text and sample output for the KnativeServing resource named
`default-knative-serving` disagree (text says `InstallSuccessful` while sample
shows `UpgradeSuccessful`) and the sentence has a grammar error; update the
descriptive sentence to match the sample output by replacing `InstallSuccessful`
with `UpgradeSuccessful` and fix the grammar to "Should return
`UpgradeSuccessful`" (refer to the `KnativeServing` example and the line
mentioning `default-knative-serving` to locate the change).
Deploying alauda-ai with
|
| Latest commit: |
4295296
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dc879c4b.alauda-ai.pages.dev |
| Branch Preview URL: | https://rls-1-5-fix-upgrade-version.alauda-ai.pages.dev |
* Add ascend 310p runtime * take advice * Fix runtime name
fyuan1316
force-pushed
the
rls-1.5/fix-upgrade-version
branch
from
4295296 to
e2a2274
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit