-
Notifications
You must be signed in to change notification settings - Fork 0
Fix thread leakage when override controller queue with withQueue
#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc4095f to
3b9cd9d
Compare
6e5a353 to
9420e57
Compare
pom.xml
Outdated
| <module>e2e</module> | ||
| <module>client-java-contrib/prometheus-operator</module> | ||
| <module>examples</module> | ||
| <!-- <module>examples</module>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
examples 的编译不需要,这部分类似于 demo,因此跳过
pom.xml
Outdated
| <layout>default</layout> | ||
| </repository> | ||
| </distributionManagement> | ||
| <!-- <distributionManagement>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
分发相关的配置,这部分我们也不需要,我们需要往我们 build-nexus 中进行分发
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些注释要不直接删掉?
withQueue
.build.yaml
Outdated
| params: | ||
| - name: command | ||
| value: | | ||
| mvn versions:set -DnewVersion=11.0.0-alauda; mvn clean deploy -DskipTests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里要不要带上 commit?
90e2df1 to
33a0030
Compare
Official Issue kubernetes-client#3738 Add about how to start with lab Signed-off-by: yuzhipeng <zpyu@alauda.io>
33a0030 to
121d247
Compare
Official Issue kubernetes-client#3738
Official PR kubernetes-client#3737