fix: silence pnpm output of detect-spec-changes #964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌿 Documentation Preview
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the GitHub Actions workflow where pnpm's output was interfering with the detect-spec-changes script output. The fix adds the -s (silent) flag to suppress pnpm's informational messages.
Changes:
- Modified the
detect-spec-changescommand to use pnpm's silent flag (-s) to prevent output pollution
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dslovinsky
had a problem deploying
to
github-pages
GitHub Actions
Failure
dslovinsky
force-pushed
the
ds/pnpm-s-fix
branch
from
a92f2a1 to
dba0099
Compare
SahilAujla
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first run of this failed. Looks like there was a bug in the GHA workflow itself caused by pnpm output overwriting the output of the detect-spec-changes script. Adding -s flag should fix it by suppressing that.
This time I tested the build step in the feature branch. You can see output here. The deploy to GH pages fails because of env protections but that's fine.
Changes Made
Call
detect-spec-changeswith-sflagTesting
pnpm run validate)