fixes for validation engine and for using torchrun#22
Merged
jgmf-amazon merged 1 commit intomainfrom Jun 22, 2022
Merged
Conversation
cperiz
approved these changes
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #21
Description of changes:
There are two fixes given:
eval_predsfunction intraining_utils.pyper the suggestion of @bozheng-hit .With the currentmainbranch, the validation engine is not functioning correctly, because subwords after the first subword are being handled by theconvert_to_biofunction. Instead, we want to merge/ignore the subsequent subwords and use only the prediction from the first subword. This change sets subsequent subwords to -100.torchrun.I tested the changes with the xlmr_base example configs, both with
train.pyandtest.py.Once these changes are approved, I'll update the README. Thanks.