Skip to content

Prevent crash on empty dice face array#1

Open
alexdeng wants to merge 1 commit intomasterfrom
codex/find-and-fix-bug-in-important-code
Open

Prevent crash on empty dice face array#1
alexdeng wants to merge 1 commit intomasterfrom
codex/find-and-fix-bug-in-important-code

Conversation

@alexdeng
Copy link
Copy Markdown
Owner

Summary

  • Avoid reduce error in dice component by providing initial value when summing faces

Testing

  • node -e "var faces=[]; console.log(faces.reduce((a,b)=>a+b,0));"
  • npm test (fails: package.json missing)

https://chatgpt.com/codex/tasks/task_e_689cf579fb68832d9f435320de9b4cc6

@alexdeng alexdeng marked this pull request as ready for review August 13, 2025 20:33
@alexdeng alexdeng requested a review from Copilot August 13, 2025 20:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants