Open
Conversation
nanashima
requested changes
Jul 2, 2022
nanashima
left a comment
nanashima
left a comment
There was a problem hiding this comment.
apple.c spear.c works.c が正しくありません．
もう一度確認してみてください．
Author
|
ターミナルから変更ができなくて、giyhubに直接アップロードしたのですが、新しいものはプルリクエストされているでしょうか？よろしくお願いします。work.cはまだわからないので出来次第提出します。 |
|
変更はちゃんと反映されています． |
Author
|
採点よろしくお願いします |
nanashima
requested changes
Jul 16, 2022
nanashima
left a comment
nanashima
left a comment
There was a problem hiding this comment.
apple spear workが正しい答えを返していないです．
またspearは計算時間かかりすぎてます．資料を参考に計算量を改善してください．
src/apple.c
Outdated
| return m; | ||
| else if (l>r) | ||
| return m+1; | ||
| else if (a[m]<x) |
src/apple.c
Outdated
| else if (a[m]<x) | ||
| return binary_search(a,x,m+1,r); | ||
| else | ||
| return binary_search(a, x, l,m-1); |
There was a problem hiding this comment.
ここも合っているかは自信ないです．
講義や資料の方法で書いた方がいいと思います．
src/spear.c
Outdated
| return ans; | ||
| } | ||
|
|
||
| int main(){ |
| else{ | ||
| lb = mid; | ||
| } | ||
| } |
| @@ -4,13 +4,42 @@ int n; | |||
| int k; | |||
| int A[100000]; | |||
Author
|
よろしくお願いいたします。 |
nanashima
requested changes
Aug 5, 2022
nanashima
left a comment
nanashima
left a comment
There was a problem hiding this comment.
appleは正しい答えを返していないです（おそらく資料中のケースでも）
spearとworksはコンパイルエラー出てます．
Author
|
何度もすみません。一応自分のパソコン上では正しくできたものです。お願いします。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.