feat(types): add reranking engine settings to types#1378
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7b4d607:
|
shortcuts
reviewed
Jan 6, 2022
Member
shortcuts
left a comment
shortcuts
left a comment
There was a problem hiding this comment.
Thanks for the PR! Small comment
Author
|
Also I'm not sure why some unit tests are failing, I don't think what I changed interacted with those? |
Member
Some of the tests are flaky, since they are shared between the API clients. If a failing test is not related to your changes, then it's good :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(types): add reranking engine settings to types
What
Updating the
SettingsandSearchOptionstypes to add two reranking properties:SearchOptions)Why
These settings already exist on the engine for some time. They are already used in the dashboard but without these type we are building up quite a few "@ts-ignore".