fix(button): Fixes default button styling accessibility#2814
Merged
Conversation
8bittitan
requested review from
NatanTechofNY,
dylantientcheu,
pipeline1987,
shortcuts and
vascobettencourt
as code owners
✅ Deploy Preview for docsearch-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for docsearch failed.
|
Contributor
|
Thanks! Are you sure this fixes the problem? Because my "light before" is significantly worse than the one you display in this PR Mine: 
Yours: 
|
Contributor
Author
|
@slorber I think the difference between ours was that the "light before" had an alpha channel on the background color 🤔 |
slorber
reviewed
Dec 23, 2025
| border-radius: 4px; | ||
| background-color: var(--docsearch-searchbox-background); | ||
| color: var(--docsearch-muted-color); | ||
| background-color: var(--docsearch-search-button-background); |
Contributor
There was a problem hiding this comment.
Just trying to understand: what's the difference between searchbox and search-button?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #2804
Fixes some accessibility issues for default search button styling in light/dark mode.
Previews
Light before
Light after
Dark before
Dark after
