chore(examples): add IE 11 legacy browser support to e-commerce examples#6968
Draft
FabienMotte wants to merge 9 commits intomasterfrom
Draft
chore(examples): add IE 11 legacy browser support to e-commerce examples#6968FabienMotte wants to merge 9 commits intomasterfrom
FabienMotte wants to merge 9 commits intomasterfrom
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 6 |
TIP This summary will be updated as you push new changes. Give us feedback
More templates
algoliasearch-helper
instantsearch-ui-components
instantsearch.css
instantsearch.js
react-instantsearch
react-instantsearch-core
react-instantsearch-nextjs
react-instantsearch-router-nextjs
vue-instantsearch
commit: |
FabienMotte
force-pushed
the
chore/examples-ie11-support
branch
from
262decf to
8d73d92
Compare
FabienMotte
force-pushed
the
chore/examples-ie11-support
branch
from
8d73d92 to
c27cc60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E2e tests for the JS e-commerce examples are failing due to missing legacy browser support. This adds
@vitejs/plugin-legacywith IE 11 targets so the built output includes the necessary polyfills and transpiled bundles.Changes:
@vitejs/plugin-legacyandterserto both e-commerce examples['defaults', 'IE 11']targets--basepaths forwebsite:examplesscriptsResult
Both e-commerce examples build with legacy browser bundles included. CI e2e tests run on this branch to validate the fix.