implement child function#317
Conversation
Render a function which render React element is now possible
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
|
I don't understand what your bot wants. |
|
Hey @DavidBabel I was rather confused by the commit bot aswell. The commit Bot enforces the commits & PRs to have a certain style. Commits must have a type and a scope. If a commit is a feature that adds a formatting for child functions the PR title could be Commits must be in a similar style. See this link for details https://www.npmjs.com/package/@commitlint/config-angular You can rewrite your old commit messages and PR title and the bot will pick up on that. Please also note that the unit tests currently fail. |
|
@DavidBabel Any update on this one? We have run into the same issue with render functions. |
|
Since it wasn't answered i forked the library with this modifications, but it's very for personnal use, i will not provide any support : https://www.npmjs.com/package/@davidbabel/react-element-to-jsx-string |
|
I'll go ahead and close this Pull Request. Feel free to Re-Open it if you want to have your changes merged into this repository. Please see my previous comment for the reason why I cannot merge this as-is. |
Render a function which render React element is now possible
Fix for #295