fix(formatting): Make the props "key" and "ref" order predictibale#340
Merged
armandabric merged 1 commit intoalgolia:masterfrom Jan 5, 2019
Merged
Conversation
Collaborator
Author
|
Close #339 |
This was referenced Jan 5, 2019
Contributor
|
This is an interesting fix, can you teach me a bit more and explain why it fixes the issue? |
Collaborator
Author
|
The order function was not stable. It return a different result depending on the order of the original props because we forgot to enforce the order between the Before the fix: console.log(['key', 'ref']).sort(propNameSorter)); // ['key', 'ref']
console.log(['ref', 'key']).sort(propNameSorter)); // ['ref', 'key']After the fix: console.log(['key', 'ref']).sort(propNameSorter)); // ['key', 'ref']
console.log(['ref', 'key']).sort(propNameSorter)); // ['key', 'ref']Why this do not trigger before? I'm not sure: maybe some react internal change ? |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and fix the CI ^^'