forwardRef fix for displayName#461
Conversation
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
armandabric
left a comment
There was a problem hiding this comment.
Thanks for this PR. Just a first quick review for now. I will have another look later
| "prettier": "1.18.2", | ||
| "react": "16.11.0", | ||
| "react-dom": "16.11.0", | ||
| "react-is": "^16.11.0", |
There was a problem hiding this comment.
We are using Yarn as package manager. You need to use it to add the dependencies yarn install react-is@^16.11.0. It will upgrade the yarn.lock file accordingly and allow the CI to run.
There was a problem hiding this comment.
I updated the pr with the lock file.
Thanks for pointing out.
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
|
Headed over here for this fix. Thanks @roedit. I think the commit messages just need correctly formatting. |
|
What's the status of this PR? We're running into this issue ourselves and would love a release of this one! |
armandabric
left a comment
There was a problem hiding this comment.
It need to be rebased on master. Thanks for this change!
Hi,
I added a fix for <[object Object] /> when using forwardRef
Regards